use explicit carets in Cargo files to work around Dependabot#162
Closed
davepacheco wants to merge 1 commit intomainfrom
Closed
use explicit carets in Cargo files to work around Dependabot#162davepacheco wants to merge 1 commit intomainfrom
davepacheco wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
Depends on #163. |
Collaborator
Author
|
I'm less optimistic this will work after this comment. It may be time to look at Renovate instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Cargo looks at dependency semver strings, it treats strings with no operator as having an implicit leading caret. However, Dependabot seems not to treat it this way, leading to the problems I mentioned in #156.
This change adds an explicit caret to all of our implicit caret dependencies. I also went back and undid the recent Cargo.toml changes that Dependabot made. This change should be safe because we tested these versions a week ago (and this PR will test them again). The benefit is that it eases the constraint on consumers, since we accept a wider range of versions.
Going forward, the hope is that:
I'm not totally sure whether this will work. I'm going by a few data points from #156 and dependabot/dependabot-core#4009. But this is pretty low risk and easy to undo.