Conversation
linusg
requested changes
Apr 15, 2025
linusg
requested changes
Apr 23, 2025
src/components/AppHeader.vue
Outdated
| <div class="nav-item"> | ||
| <CalendarIcon size="1x" aria-hidden="true" role="img" /> | ||
| <date-picker | ||
| v-if="datePickerLang" |
Co-authored-by: Linus Groh <mail@linusgroh.de>
mschreiber
commented
Apr 24, 2025
Contributor
Author
mschreiber
left a comment
mschreiber
left a comment
There was a problem hiding this comment.
Thanks for the review and the suggestions, which make sense!
removing unnecessary if
linusg
reviewed
Apr 24, 2025
Member
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
LGTM though I want to test this locally before merging :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamically imports the required vue-datepicker locale bundles (e.g., 'de', 'fr', 'en') and assign it to the datepicker component "lang" property. Falls back to 'en' if the browser language is not supported.