Add 'bag-it' extension to extensions.json#116
Add 'bag-it' extension to extensions.json#116escotop wants to merge 1 commit intoowlbear-rodeo:mainfrom
Conversation
|
Validation script and image URLs check out fine. Extension functionality and API usage not checked. |
nthouliss
left a comment
There was a problem hiding this comment.
@escotop at the moment the extension is cancelling selection when the bag it open. Could you let me know why you're doing this? At the moment I can't accept the extension because of this. The bag also blocks the tools so the window would need to be moved so it doesn't overlap on these.
|
Once the bag is open, it caused issues letting the user use the context
options of the item. So deselecting it, is a way to prevent accessing them,
due to that once closed via deselecting it, you cant access it again unless
u close the bag first.
The one of covering the tools, to position the bag window popover there are
via api 2 options: Predetermined positions or coordinates. The problem with
the coordinates is that they are absolute, not proportional, so it causes
issues with different screen sizes. So the window uses the predetermined
positions, i could move it to the center or down but considering the usual
position of other extension windows, and also letting the user space to
drag items into the bag, the current one seems like the best position. And
im not aware if there is, of an option to modify the x or y axis of the
predetermined positions
El vie, 5 dic 2025 a las 0:12, Nicola Thouliss ***@***.***>)
escribió:
… ***@***.**** requested changes on this pull request.
@escotop <https://github.com/escotop> at the moment the extension is
cancelling selection when the bag it open. Could you let me know why you're
doing this? At the moment I can't accept the extension because of this. The
bag also blocks the tools so the window would need to be moved so it
doesn't overlap on these.
—
Reply to this email directly, view it on GitHub
<#116 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI5VBVYUG3PDMBFNBJLRJNT4AC5VXAVCNFSM6AAAAACM6FTX7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNBSGUYTEOBWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@escotop Could you elaborate more on the issue that you had with the user using the context of the item? We might be able to suggest some fixes or workarounds. I just don't want to risk users not being able to use the core site functionality. I'll chat with Mitch more about the tool location but there could be some delay. Sorry for the wait, it's been a long Decemeber/Jan :) |
|
No need for the contextmenu one, updated it and now it doesnt deselect the
token, should solve that. The one of the window position is what i said,
via api we dont have perfect control of the windows position without
misspositioning it for some users depending of the screen size.
El jue, 29 ene 2026 a las 0:11, Nicola Thouliss ***@***.***>)
escribió:
… *nthouliss* left a comment (owlbear-rodeo/extensions#116)
<#116 (comment)>
@escotop <https://github.com/escotop> Could you elaborate more on the
issue that you had with the user using the context of the item? We might be
able to suggest some fixes or workarounds. I just don't want to risk users
not being able to use the core site functionality.
I'll chat with Mitch more about the tool location but there could be some
delay.
Sorry for the wait, it's been a long Decemeber/Jan :)
—
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI5VBV2NHNASEUHGWJRKFI34JE62ZAVCNFSM6AAAAACM6FTX7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMJUGQYDCOJQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Make sure that your submission has the following:
Please, go through these steps before you submit a PR.
You have done your changes in a separate branch.
You have a descriptive commit message with a short title (first line).
You have only one commit (if not, squash them into one commit).
Your pull request MUST target the
mainbranch on this repository.Your pull request puts your extensions details as the last entry in the extensions.json file