encapsulated as much as possible, with low logical changes#5
Open
nickma82 wants to merge 1 commit intoowagner:masterfrom
Open
encapsulated as much as possible, with low logical changes#5nickma82 wants to merge 1 commit intoowagner:masterfrom
nickma82 wants to merge 1 commit intoowagner:masterfrom
Conversation
Focused on as less changes as possible to the code logic in this first step, in order to make the changes comprehensible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
could you please review my changes and tell me what you think!?
I tried to get it into an object oriented style, for better maintainability and as a preparation for further enhancements (e.g. automated test cases).
There are still - nice to have beautifying - changes which I omitted in this step in the sense of comprehensibility (I left a couple of TODO's though).
Best, Nick