Support installing LXD from snap #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While not the most popular option a lot of people use it to get LXD up and running fast. Changes made: * Added variable to control how `lxd` is expected to be installed. Defaults to `deb`. * Added logic to determine how to install the package (package resource or snap exec)
Previously, when running `class { 'lxd': ensure => absent}` it would
uninstall lxd and then attempt to change config values, which would result
in errors. As such it's better in such case to do that before removing lxd.
* Included tests for all supported OS's as per metadata.json * Add test to validate install & uninstall order * Fix tests for deb & snap installs
The change would make it easier for future support of non-Debian family OS's.
Author
|
Closing this one as I messed up branches & included untested commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not the most popular option a lot of people use it to get LXD up and running fast. Changes made:
lxdis expected to be installed. Defaults todeb. If support for non-Debian family OS's is expected to be handled by the module, it might make sense to rename thedeboption to something else. As per the project description, it doesn't seem to be any such plans.snapdwill be managed by the module, but I can easily switch it to be a configurable option that defaults to true.