Issue #73 - Move /games/username to /player/username #75
Conversation
src/app/app.module.ts
Outdated
| { path: 'video', component: VideoSearchComponent }, | ||
|
|
||
| { path: 'discord', component: DiscordRedirect }, | ||
| { path: 'games/:share_key', redirectTo: '/player/:share_key' }, |
There was a problem hiding this comment.
should this be in a component like the discord redirect?
There was a problem hiding this comment.
The discord redirect is because he's doing special logic to change the window.location. This redirect is in app, so no need.
There was a problem hiding this comment.
Yeah, but I just thought I'd propose it for consistencies sake.
There was a problem hiding this comment.
I'd say nah. If both the routes go to the same component, there's some duplicated code. It's an extremely minor thing, but I think it's probably better to have the redirect chain so that if you for some reason change the component someday, you only have to do it in one place and it changes for both.
benolot
changed the title
|
A problem I see with this is people can have multiple share links, so Most share links are in the format -, but people can generate separate links with some some just doing just one account, some doing others, and some doing all games including customs. |
3 participants
Let me know if this works... or not. I don't know angular.
#73