Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Add tests using bench brick to generate pings.#398

Open
outscale-fne wants to merge 5 commits intooutscale:developfrom
outscale-fne:fnouaille
Open

Add tests using bench brick to generate pings.#398
outscale-fne wants to merge 5 commits intooutscale:developfrom
outscale-fne:fnouaille

Conversation

@outscale-fne
Copy link
Contributor

No description provided.

Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
@outscale-mgo
Copy link
Contributor

Can one of the admins verify this patch?

@outscale-fne outscale-fne changed the title Add "real" tests using bench brick, testing the ping output. Add tests using bench brick to generate pings. Feb 19, 2020
@outscale-fne
Copy link
Contributor Author

@outscale-toa changes done!

@outscale-fne outscale-fne force-pushed the fnouaille branch 3 times, most recently from 40add99 to b2fcb27 Compare February 26, 2020 13:06
Copy link
Contributor

@outscale-mgo outscale-mgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So The test seems ok 2 me, 2 note though:

function return_result {
clean_all
if [ $RETURN_CODE == 0 ]; then
echo $CUR_TEST 'SUCESS !!!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, can you move this to another commit please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

de suite!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants