Skip to content

Amélioration de la robustesse des vérifications de pages spéciales #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnaudlevy merged 3 commits into from
Jan 6, 2026
Merged

Amélioration de la robustesse des vérifications de pages spéciales #3690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93fc62f
education
arnaudlevy Jan 5, 2026
b81ccdb
fix tests
arnaudlevy Jan 6, 2026
3024b0c
Merge branch 'main' into special-pages-check
arnaudlevy Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/communication/website/page/education_diploma.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def is_hugo_index?
end

def should_create_special_page?
website.about && website.about&.respond_to?(:education_diplomas)
website.has_education_diplomas?
end

def editable_width?
Expand Down
2 changes: 1 addition & 1 deletion app/models/communication/website/page/education_program.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def is_hugo_index?
end

def should_create_special_page?
website.about && website.about&.respond_to?(:programs)
website.has_education_programs?
end

def editable_width?
Expand Down
2 changes: 1 addition & 1 deletion app/models/communication/website/page/education_school.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def is_hugo_index?
end

def should_create_special_page?
website.about && website.about&.respond_to?(:education_schools)
website.has_education_schools?
end

def editable_width?
Expand Down
6 changes: 3 additions & 3 deletions test/models/communication/website/dependency_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ def test_change_website_dependencies
# - Les catégories d'actus liés aux formations, soit la catégorie racine et la catégorie de default_program, ainsi que leurs localisations (4)
# - Les catégories d'agenda liés aux formations, soit la catégorie racine et la catégorie de default_program, ainsi que leurs localisations (4)
# - Les catégories de pages liés aux formations, soit la catégorie racine et la catégorie de default_program, ainsi que leurs localisations (4)
# - Les pages "Teachers", "Administrators", "Researchers", "EducationDiplomas", "EducationPrograms", "AdministrationLocation" et leurs localisations (12)
# Donc un total de 6 + 4 + 4 + 4 + 12 = 30 dépendances
assert_equal 30, delta
# - Les pages "Teachers", "Administrators", "Researchers", "EducationDiplomas", "EducationPrograms", "EducationSchools", "AdministrationLocations" et leurs localisations (14)
# Donc un total de 6 + 4 + 4 + 4 + 14 = 32 dépendances
assert_equal 32, delta

clear_enqueued_jobs
end
Expand Down
Loading