Skip to content

Ajout d'un conseil dans la bibliothèque de médias #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sachaandre wants to merge 11 commits into
base: main
Choose a base branch
from
+7 −4
Open

Ajout d'un conseil dans la bibliothèque de médias #3252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c984963
Adding hint to internal_description field when adding a media
sachaandre Jul 19, 2025
2f1a2da
correction fr
sachaandre Jul 19, 2025
a223b99
Corrections suite commentaires PR + Changement phrasé
sachaandre Jul 23, 2025
e04e008
removing line from form
sachaandre Jul 23, 2025
b49db8b
Changes to resolve #3262
sachaandre Jul 23, 2025
a046c94
Merge branch 'main' into adding-hint-mediatheque
arnaudlevy Jul 31, 2025
3cd2ed6
Merge branch 'main' into adding-hint-mediatheque
arnaudlevy Aug 25, 2025
18e3016
Merge branch 'main' into adding-hint-mediatheque
arnaudlevy Sep 8, 2025
43f1dd2
Merge branch 'main' into adding-hint-mediatheque
arnaudlevy Sep 11, 2025
d2aa896
Merge branch 'main' into adding-hint-mediatheque
arnaudlevy Nov 12, 2025
acaa34b
Merge branch 'main' into adding-hint-mediatheque
arnaudlevy Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/views/admin/communication/medias/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
'summernote-config' => 'link'
}
} %>
<%= lf.input :internal_description %>
<%= lf.input :internal_description,
hint: t('internal_description_hint') %>
Copy link
Member

@pabois pabois Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il est inutile de forcer l'affichage d'un hint comme ça.
Si tu veux qu'un hint soit affiché il y a déjà une mécanique automatique qui le fait, à condition que tu mettes ta locale au bon endroit.
Il faut bouger ta clé pour qu'elle soit dans simple_form/hints/communication_media_localization/internal_description et ca l'affiche tout seul

</div>
</div>
<% content_for :action_bar_right do %>
Expand Down
2 changes: 1 addition & 1 deletion config/locales/communication/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ en:
communication/media/collection/localization:
name: Name
communication/media/localization:
internal_description: Internal description
internal_description: Internal description
Copy link
Member

@pabois pabois Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cet espace ajouté ne sert à rien

name: Name
communication/website:
about: About
Expand Down
3 changes: 2 additions & 1 deletion config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ en:
templates:
embed:
title_missing:
text_html: The HTML embedding has not title. This will prevent blind people from knowing what the content is about, as mentioned in <a href="https://www.numerique.gouv.fr/publications/rgaa-accessibilite/methode-rgaa/criteres/#topic4" target="_blank">criterion 4.7 of RGAA</a>. Please add a title to the iframe.
text_html: The HTML embedding has not title. This will prevent blind people from knowing what the integrated content is about, as mentioned in <a href="https://www.numerique.gouv.fr/publications/rgaa-accessibilite/methode-rgaa/criteres/#topic4" target="_blank">criterion 4.7 of RGAA</a>. Please add a title to the iframe.
title: No frame title
transcription_missing:
text_html: The HTML iframe has no text transcription for blind people, for people with low bandwidth or no javascript enabled. Please add a text transcription.
Expand Down Expand Up @@ -412,6 +412,7 @@ en:
status: "Status:"
still_pending: "Your import has not been processed yet. You will receive an email as soon as it's ready."
inactivity_alert: "It seems you have been away a little bit too long. Could you please retry?"
internal_description_hint: Complementary description of the image for the media library users. You can write this text to help the media library users to find an image, have complementary informations about it or have special instructions regarding the use of the image.
Copy link
Member

@pabois pabois Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ce n'est pas le bon endroit pour cette clé

Copy link
Member

@arnaudlevy arnaudlevy Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachaandre ce que veut dire @pabois c'est qu'il y a des clés conventionnelles pour les hints, de la forme suivante

  simple_form:
      communication_extranet:
        favicon: 'Fichier .png uniquement'

Copy link
Member

@pabois pabois Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(remarque bien que c'est ce que j'avais expliqué au commentaire d'avant :p )

internationalization:
label: Internationalization
legal: Legal
Expand Down
3 changes: 2 additions & 1 deletion config/locales/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ fr:
templates:
embed:
title_missing:
text_html: L'intégration HTML n'a pas de titre, cela va empêcher les personnes malvoyantes de savoir de quoi parle le contenu, comme expliqué dans le <a href="https://www.numerique.gouv.fr/publications/rgaa-accessibilite/methode-rgaa/criteres/#topic4" target="_blank">critère 4.7 du RGAA</a>. Merci d'ajouter une balise <b>title</b> explicite à votre iframe.
text_html: L'intégration HTML n'a pas de titre, cela va empêcher les personnes malvoyantes de savoir de quoi parle le contenu intégré, comme expliqué dans le <a href="https://www.numerique.gouv.fr/publications/rgaa-accessibilite/methode-rgaa/criteres/#topic4" target="_blank">critère 4.7 du RGAA</a>. Merci d'ajouter une balise <b>title</b> explicite à votre iframe.
title: Pas de titre de cadre
transcription_missing:
text_html: Le cadre HTML n'est pas accompagné d'une transcription textuelle pour les personnes malvoyantes, ou pour les situations de faible débit qui empêcheraient la lecture.
Expand Down Expand Up @@ -412,6 +412,7 @@ fr:
status: "Statut :"
still_pending: "Votre import est toujours en cours de traitement. Vous recevrez un email dès qu'il est prêt."
inactivity_alert: "Il semble que vous soyez resté sur la page un peu trop longtemps. Pouvez-vous ré-essayer ?"
internal_description_hint: Description complémentaire de l'image. Vous pouvez donner des informations complémentaires sur l'image, utiles pour la recherche et indiquer des instructions spécifiques d'usage pour les utilisateur·rices de la médiathèque.
Copy link
Member

@pabois pabois Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem que en, pas le bon endroit

internationalization:
label: Internationalisation
legal: Légal
Expand Down
Loading