Fix for failure when dev environment is on non-C: drive#1
Open
DanAndersen wants to merge 1 commit intoortclib:releases/m62from
Open
Fix for failure when dev environment is on non-C: drive#1DanAndersen wants to merge 1 commit intoortclib:releases/m62from
DanAndersen wants to merge 1 commit intoortclib:releases/m62from
Conversation
|
@vmancic Can you review this pull request please? |
|
Changes approved. P.S. |
vmancic
approved these changes
May 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running vcvarsall.bat during compilation, the current directory switches to the Users directory and has to be changed back to the original winbuild folder. However, if ortclib is being built on a drive that is not C:, the
CDcommand will fail. This pull request adds the/Dflag to allow for cross-drive directory changes.