METRIC="en_UK" is incorrect or at least confusing.#156
Open
JustinGardiner wants to merge 1 commit intoorcasgit:masterfrom
JustinGardiner:patch-1
Open
METRIC="en_UK" is incorrect or at least confusing.#156JustinGardiner wants to merge 1 commit intoorcasgit:masterfrom JustinGardiner:patch-1
JustinGardiner wants to merge 1 commit intoorcasgit:masterfrom
JustinGardiner:patch-1
Conversation
I just wanted to point out that it is confusing to have US = 'en_US' METRIC = 'en_UK' because the only reason 'en_UK' gets you metric is because it is an incorrect form of what I'd assume is supposed to be 'en_GB', the language tag for British English. Also, this is confusing because the 'en_GB' tag isn't metric but British (so it uses stones, for example). See here: https://dev.fitbit.com/build/reference/web-api/basics/#units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wanted to point out that it is confusing to have
US = 'en_US'
METRIC = 'en_UK'
because the only reason 'en_UK' gets you metric is because it is an incorrect form of what I'd assume is supposed to be 'en_GB', the language tag for British English. Also, this is confusing because the 'en_GB' tag isn't metric but British (so it uses stones, for example).
See here: https://dev.fitbit.com/build/reference/web-api/basics/#units