Add Django 2 support and update other dependencies.#44
Open
kblicharski wants to merge 33 commits intoorcasgit:masterfrom
Open
Add Django 2 support and update other dependencies.#44kblicharski wants to merge 33 commits intoorcasgit:masterfrom
kblicharski wants to merge 33 commits intoorcasgit:masterfrom
Conversation
The `on_delete` kwarg was added and the import syntax of `reverse` was changed in all found locations.
Also adds two new dev dependencies for convenience.
Add Django 2 support
Author
|
The CI jobs are all failing due to supporting Django 1.9 and lower. I'm not sure how to add this feature while still retaining backwards compatibility for these versions of Django, so if the maintainers of this repository are still active, it's up to them whether it's worth deprecating and removing Django versions 1.8 and 1.9. |
going to fix failing tests next
…ay_data when appropriate.
…enter/django-fitbit into intraday-support-redo
|
@kblicharski Has the source branch for this PR been removed? I would like to fetch it and merge locally since the PR doesn't seem to be going into this repo. |
|
Ah never mind, just noticed that the account was not @kblicharski , but rather @thesignalcenter |
Member
|
@rahul003 You're right, this PR will not be merged in. We will add 2.0 support without all the other extra changes this PR includes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
django.core.urlresolvers import reversebecamefrom django.urls import reverseuser.is_authenticated()becameuser.is_authenticatedMIDDLEWARE_CLASSESbecameMIDDLEWAREon_deletekwarg was added to all ForeignKeys/OneToOneFields/etcI also added
pip-reviewandpipdeptreeas dev dependencies and reformatted the code to remove unused imports and add/remove newlines as needed.