Skip to content

Fix MFD related crashes caused by checklists not fully loading #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lassombra wants to merge 2 commits into
base: Orbiter2016
Choose a base branch
from
Draft

Fix MFD related crashes caused by checklists not fully loading #1371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b08a2ab
Checklist File Crash fix
lassombra Feb 22, 2025
02b327e
Merge branch 'orbiternassp:Orbiter2016' into checklist-crashes
lassombra Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Orbitersdk/samples/ProjectApollo/src_mfd/ProjectApolloChecklistMFD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,17 @@ bool ProjectApolloChecklistMFD::Update (oapi::Sketchpad* skp)

// Make sure that the HiLghtdLine is shown actually
bool hiLghtdLineShown = false, redo = true;
if (NumChkLsts == 0) {
//If we end up here, we need to not try to iterate through the screen
//and instead effectively abort - somehow we have no checklists to show
//This would likely be caused by a parsing error when loading the checklist file
redo = false;
TopStep = 0;
skp->SetTextColor(RGB(225, 0, 0)); // red
skp->SetTextAlign(oapi::Sketchpad::CENTER);
line = "No Checklists Available";
skp->Text((int)(width * .5), (int)(height * 0.10), line.c_str(), line.size());
}
while (redo) {
grpcnt = 0;
for (cnt = 0; cnt < NLINES; cnt++) {
Expand Down