Replace dependency on community IPFS types with new ipfs-core-types#31
Open
mboogerd wants to merge 1 commit intoorbitdb:mainfrom
Open
Replace dependency on community IPFS types with new ipfs-core-types#31mboogerd wants to merge 1 commit intoorbitdb:mainfrom
mboogerd wants to merge 1 commit intoorbitdb:mainfrom
Conversation
Also fix a reported error with IReplicationStatus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi! 👋
I encountered issue #29 and thought I would attempt to help.
Disclaimer:
The problem:
IPFS type from
git+https://github.com/lukas2005/types-ipfs.gitdon't match the types employed by the more recentipfs-core-typespackage. This package seems to be the new way of working, at least for ipfs-http-client.The fix:
@types/ipfswithipfs-core-typesCannot find name 'IReplicationStatus'.. This seems to be fixed by adding a reference path. I don't understand the details of what it does, but I see a similar usage in OrbitDB.d.ts, so I guess it's okay? :)Cannot find module 'orbit-db-cache' or its corresponding type declarations.. My intuition here is that we shouldn't use this git dependency on OrbitDB, but have a release cycle for the types that aligns with the releases of OrbitDB. I could be entirely wrong here though. Also not sure whether that should be fixed in this PRFeedback much appreciated! :)