POC Capi v3 for service bindings #234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen broker returns sync response. As a result, the CreateDeleteAsyncInstanceWithSyncBackingServiceKeysAcceptanceTest fails with error Service broker error: backing osb-cmdb broker requires async Corresponding code base: https://github.com/cloudfoundry/cloud_controller_ng/blob/f75acb00ad139599921d3237005d6b6a949b3dae/spec/support/shared_examples/v3_service_binding_create.rb#L22-L30
CreateDeleteAsyncInstanceWithSyncBackingServiceKeysAcceptanceTest: service binding response without binding id
…to pass along the job id to fallback. Might require zip/tuple pattern from cf-java-client operations https://github.com/cloudfoundry/cf-java-client/blob/8b8a56a3eaf700fd8eeeab55e61a1926c6a76747/cloudfoundry-operations/src/main/java/org/cloudfoundry/operations/spaces/DefaultSpaces.java#L113
…b id to fallback." This reverts commit 88c17002bec5d58748db9fdbf96a0c8d902c1985.
…ing V3 to get service instance in backing space, with potentially creating the space on the fly Removed dead v2-based CSK
… rather try to contribute it to cf-java-client" This reverts commit 2a2505cc78830ab7edd16ad000b281581b4ff279.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incomplete POC aiming to replace V2 api calls with V3 for service bindings following #231
fix #44