chore: Rework setup script

[halostatue]

Addresses #20 (comment).

[halostatue]

I’m going to heavily annotate the changes I made to explain why. It makes a lot of changes that may or may not work with your ultimate goals, but inasmuch as I can test it locally (when I have everything except PostgreSQL installed), it seems to work once I added a DRY_RUN flag.

$ mkdir z && touch z/{.bashrc,.zshrc}
$ DRY_RUN=1 HOME=z priv/scirpt.sh

[almirsarajcic]

Wow, the best PR I've seen in my life!
Thanks for all the annotations. My shell scripting is bad, so this is a huge learning opportunity for me.

Most of the things you've changed I agree with. The rest I don't understand yet.

I'm only worried about whether we'll still be able to run the GitHub Actions workflow with these changes.
We don't have much in the expect script, so I thought our tests would be robust enough.

phx.tools/test/scripts/script.exp

Lines 1 to 9 in a24a101

	#!/usr/bin/expect
	set script [lindex $argv 0]
	set timeout -1
	spawn ./../../priv/script.sh
	match_max 100000
	expect "Do you want to continue? (y/n) "
	send -- "y\r"
	expect eof

But they failed at line

spawn ./../../priv/script.sh
tput: No value for $TERM and no -T specified

[halostatue]

Wow, the best PR I've seen in my life! Thanks for all the annotations. My shell scripting is bad, so this is a huge learning opportunity for me.

Thanks for the kind words. I’ve been shell scripting for decades now, so this really wasn't too hard.

Most of the things you've changed I agree with. The rest I don't understand yet.

I'm only worried about whether we'll still be able to run the GitHub Actions workflow with these changes. We don't have much in the expect script, so I thought our tests would be robust enough.

I didn't look at this from the perspective of testing, but from user experience. The test failures did point out a bug, and I should have tested for it, but it's sort of hard to test for on a machine. I’ve put a fixup commit that should resolve the test failures in the expect script. It makes a couple of changes to the expect script to make sure that a bit more is seen than was previously expected.

[almirsarajcic]

spawn ./../../priv/script.sh
Unsupported shell: bash
expect: spawn id exp3 not open
    while executing
"expect "phx.tools setup is complete!""
    (file "script.exp" line 13)

This time I think it's because of this line
https://github.com/optimumBA/phx.tools/pull/27/files#diff-5cd7660b84bc8ab514a6b77b04c735c4581ddde80ed19035e9f08ded4a34aa50R83

*/bash | */fish | */zsh) : ;;

phx.tools/.github/workflows/pr.yml

Lines 289 to 292 in a24a101

	- name: Test the script
	if: steps.result_cache.outputs.cache-hit != 'true'
	run: cd test/scripts && expect script.exp
	shell: bash -l {0}

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell
Not sure if /bin/ prefix works for the shell option.

[halostatue]

I'll look at that a bit later. Probably by pushing a debugging fix.