Skip to content

Conversation

@lbillinghamwrk
Copy link

Not totally sure we want to do all of this (or indeed any of it).

  • make our max line length sensible
    • unlike the 730 chars that we inherited from errbot's pyproject.toml/setup.cfg
  • run black over the codebase to autoformat it
  • since ruff is the linter defined in the project file: run ruff's auto fix
  • manually fix a couple of things that ruff couldn't
  • silence the warning for use of the global and apologise for it

Comment on lines 1 to 10
[tool.black]

# no custom config yet

[tool.ruff]
# lol sob see setup.cfg
line-length = 730
line-length = 120

# this should match what is in Dockerfile
target-version = "py312"
target-version = "py39"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panneeran
even if we don't want to take the other changes in this PR,
i think its still worth having the pyproject line length be sensible, and aligning python versions between here and the Dockerfile

FROM python:3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant