Updates to ensure connections are closed in ConnectionManager and tests#184
Open
aparod wants to merge 3 commits intoopt-elixir:masterfrom
Open
Updates to ensure connections are closed in ConnectionManager and tests#184aparod wants to merge 3 commits intoopt-elixir:masterfrom
aparod wants to merge 3 commits intoopt-elixir:masterfrom
Conversation
Collaborator
|
Hey @aparod I just saw this. I'll take a look asap and get back to you. |
Collaborator
|
Lines 46 and 51 do look like places where it should be called. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All non-enterprise tests are now passing against the version of Faktory provided in
docker-compose.yml.Note: It's not clear to me if
close_connection/1should be called from other places inFaktoryWorker.ConnectionManager.send_command/3, here and here. Thoughts?