Skip to content

Updates to ensure connections are closed in ConnectionManager and tests#184

Open
aparod wants to merge 3 commits intoopt-elixir:masterfrom
aparod:fix_tests
Open

Updates to ensure connections are closed in ConnectionManager and tests#184
aparod wants to merge 3 commits intoopt-elixir:masterfrom
aparod:fix_tests

Conversation

@aparod
Copy link
Contributor

@aparod aparod commented Apr 7, 2023

  • Make sure connections get closed for commands that failed their first attempt
  • Update tests to expect the socket being closed
  • Update inaccurate README testing instructions

All non-enterprise tests are now passing against the version of Faktory provided in docker-compose.yml.

Note: It's not clear to me if close_connection/1 should be called from other places in FaktoryWorker.ConnectionManager.send_command/3, here and here. Thoughts?

@Ch4s3
Copy link
Collaborator

Ch4s3 commented Jun 12, 2023

Hey @aparod I just saw this. I'll take a look asap and get back to you.

@Ch4s3
Copy link
Collaborator

Ch4s3 commented Jun 12, 2023

Lines 46 and 51 do look like places where it should be called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants