Skip to content

Conversation

@benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Dec 2, 2025

Type hints could be more precise thanks to @overload python feature (see https://typing.python.org/en/latest/spec/overload.html)

@benoit74 benoit74 self-assigned this Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.63%. Comparing base (26e3ab1) to head (1893e14).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/zimscraperlib/image/optimization.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   99.87%   99.63%   -0.25%     
==========================================
  Files          41       41              
  Lines        2480     2493      +13     
  Branches      340      346       +6     
==========================================
+ Hits         2477     2484       +7     
- Misses          1        7       +6     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 requested a review from rgaudin December 2, 2025 13:54
@benoit74 benoit74 added this to the 5.4.0 milestone Dec 2, 2025
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks tests ; otherwise LGTM

@benoit74
Copy link
Collaborator Author

benoit74 commented Dec 2, 2025

Sorry, I forgot to fix PR number in CHANGELOG, hence the force push

@benoit74
Copy link
Collaborator Author

benoit74 commented Dec 2, 2025

I don't think it lacks tests, this is just a "bug" in coverage report. These methods are "fictive" and never really executed

@benoit74 benoit74 merged commit 9904777 into main Dec 2, 2025
7 of 9 checks passed
@benoit74 benoit74 deleted the add_overloads branch December 2, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants