Skip to content

Conversation

@smallprogram
Copy link
Contributor

@smallprogram smallprogram commented Jan 29, 2026

📦 Package Details

Maintainer: @1715173329 @hnyman @jmarcet
(You can find this by checking the history of the package Makefile.)

Description:

Changes: docker/cli@27.x...v29.2.0


Related PR

#28451
#28453
#28454
#28455

🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT
  • OpenWrt Target/Subtarget: x86/64
  • OpenWrt Device: QEMU

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@GeorgeSapkin
Copy link
Member

GeorgeSapkin commented Jan 29, 2026

Aside from formalities, please put changelog under Changelog: or Changes:, as this doesn't fix anything.

Did check the other PR with Docker update issues?

Edit: also, how exactly did you test all of these related PRs?

update info: docker/cli@27.x...v29.2.0

Signed-off-by: David Mandy <smallprogramzhusir@gmail.com>
@GeorgeSapkin
Copy link
Member

GeorgeSapkin commented Jan 30, 2026

You need to reset PKG_RELEASE in the same commit as the version bump.

Commit message is still messed up.

And again, how did you test this and did you see the other PR?

@smallprogram

This comment was marked as off-topic.

Changes: docker/cli@27.x...v29.2.0

Signed-off-by: David Mandy <smallprogramzhusir@gmail.com>
@GeorgeSapkin
Copy link
Member

GeorgeSapkin commented Jan 30, 2026

The rules are applied the same to everybody. Commit subject and message are not the same thing, so your screenshot makes no sense. Your commit messages are poorly-formatted again. I thought we figured it out how to format them after multiple rounds of retrying in your previous PR. Before starting and argument consider reviewing your patch:

This is the third time I'm asking you to clarify how you tested these changes, considering previous Docker PRs don't build. And you still haven't squashed your commits.

Edit: and you didn't tag the correct maintainer in any of these PRs.

@smallprogram
Copy link
Contributor Author

The rules are applied the same to everybody. Commit subject and message are not the same thing, so your screenshot makes no sense. Your commit messages are poorly-formatted again. I thought we figured it out how to format them after multiple rounds of retrying in your previous PR. Before starting and argument consider reviewing your patch:

This is the third time I'm asking you to clarify how you tested these changes, considering previous Docker PRs don't build. And you still haven't squashed your commits.

Edit: and you didn't tag the correct maintainer in any of these PRs.

sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants