Skip to content

Conversation

@tru7
Copy link
Contributor

@tru7 tru7 commented Jan 13, 2026

📦 Package Details

Maintainer: @tru7
(You can find this by checking the history of the package Makefile.)

Description:

new upstream release 0.14.75


🧪 Run Testing Details

  • OpenWrt Version: snapshot
  • OpenWrt Target/Subtarget: ath79/generic, ramips/mt7620a
  • OpenWrt Device: tplink_archer-c7-v4

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@tru7
Copy link
Contributor Author

tru7 commented Jan 14, 2026

@commodo @hnyman @neheb
Sorry to ping you - I need some expert help here, please.
All Builds (suddenly) fail on "Dirty patches detected, please refresh and review the diff". These patches have been used since years and never made problems. In the 0100-version.patch I need to change the version number - that's all I change on patches.
I also don't understand the mechanism how the patches are applied within these Builds and in what aspect there are dirty.

@hnyman
Copy link
Contributor

hnyman commented Jan 14, 2026

Just do make package/knxd/refresh V=s . And see what changes. (Possibly a make clean for that package needed earlier)

Likely it is just about missing context at the @@ line or something like that.

@tru7
Copy link
Contributor Author

tru7 commented Jan 14, 2026

Thank you @hnyman - you are right - unfortunately I overlooked a change in the upstream file after the @@
I must have overlooked a hint in my local environment - and when I tried to reproduce I didn't realize that the patch was obviously changed.
Now I tried to update my commit but I guess I messed it up. The content is still OK but there are now two commits. I'm just too unexperienced to resolve this in a clean way myself.
Can that still be resolved or should I close the PR and start over?

@hnyman
Copy link
Contributor

hnyman commented Jan 14, 2026

It is actually pretty easy to fix with git rebase. (Squash the two commits)
Read the advice from CONTRIBUTING.md

new upstream release 0.14.75
remove obsolete patch 0110-configure.ac.patch

Signed-off-by: Othmar Truniger <github@truniger.ch>
@tru7 tru7 closed this Jan 14, 2026
@tru7 tru7 deleted the knxd branch January 14, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants