Closed
Conversation
BKPepe
reviewed
Jul 13, 2025
BKPepe
reviewed
Jul 13, 2025
|
|
||
| PKG_SOURCE_PROTO:=git | ||
| PKG_SOURCE_VERSION:=v$(PKG_VERSION) | ||
| PKG_SOURCE_URL:=https://github.com/digitalocean/prometheus-client-c.git |
Member
There was a problem hiding this comment.
How this is relevant to libprom? 🤔
Contributor
Author
There was a problem hiding this comment.
The project consists of two C libraries - libprom and libpromhttp in prom and promhttp subdirs.
And original packaging names them as libprom: https://github.com/digitalocean/prometheus-client-c/blob/master/prom/CMakeLists.txt#L129
Member
|
Why we should add unmaintained library? |
Contributor
Author
|
@BKPepe it is required to be able to enable Prometheus instrumentation in Coturn: https://github.com/coturn/coturn/blob/master/docker/coturn/debian/Dockerfile#L36 There some fork, but i don't know which can be treated as an supported one. |
vooon
force-pushed
the
libprom-0.1.3
branch
2 times, most recently
from
c2f0c3e to
41d651f
Compare
Add prometheus instrumentation library for C, dependency for Coturn. Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @vooon
Description:
Add prometheus instrumentation library for C, dependency for Coturn.
See also: openwrt/telephony#912
🧪 Run Testing Details
✅ Formalities