Skip to content

Conversation

@feckert
Copy link
Member

@feckert feckert commented Aug 16, 2024

Maintainer: @mars642
Compile tested: x86_64
Run tested: no

Description:
The basicstation build fails since the change to the new major version 3.x of mbedtls, because of API changes in the new mbedtls version.

To fix the compilation for new mbedtls version, the waiting pullrequest is backported as a patch.

Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198

@github-actions
Copy link

OpenWrt will change to the APK package manager which requires
deterministic verisons. Please make sure that PKG_VERSION
follows Semantic Versioning or more specifically,
the APK version scheme.
If the version is based on a date, please use dots instead of dashes, i.e. 24.01.01.

The PKG_RELEASE should be an integer and not contain any letters or special characters.

  • net/basicstation/net/basicstation/Makefile

@BKPepe
Copy link
Member

BKPepe commented Aug 16, 2024

I am not so sure, upstream does not appear to be interested in their project anymore. It leads that if there is some security vulnerability, then we would be on our own. Same happens with bugs, etc. Your backported patch is for more than one month on review, it was not reviewed, but @gstrauss do the good job however.

I think, we should drop this package and just move on.

@neheb
Copy link
Contributor

neheb commented Aug 16, 2024

@aparcar this CI failure doesn't look right.

PKG_RELEASE:=2

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=https://codeload.github.com/lorabasics/basicstation/tar.gz/v$(PKG_VERSION)?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to local tarballs should fix CI.

@aparcar
Copy link
Member

aparcar commented Aug 16, 2024

@aparcar this CI failure doesn't look right.

The datacenter went offline and I had to switch DNS/server, should work again.

The basicstation build fails since the change to the new major version
3.x of mbedtls, because of API changes in the new mbedtls version.

To fix the compilation for new mbedtls version, the waiting pullrequest
is backported as a patch.

Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
@feckert feckert force-pushed the pr/20240816-basicstation branch from 12dde9c to b366b54 Compare August 19, 2024 07:09
@feckert
Copy link
Member Author

feckert commented Aug 19, 2024

I am not so sure, upstream does not appear to be interested in their project anymore. It leads that if there is some security vulnerability, then we would be on our own. Same happens with bugs, etc. Your backported patch is for more than one month on review, it was not reviewed, but @gstrauss do the good job however.

I think, we should drop this package and just move on.

I have now opened an issue to see if the project is still active

@aparcar
Copy link
Member

aparcar commented Aug 19, 2024

Cool, APK is happy now.

@neheb neheb merged commit a890892 into openwrt:master Aug 19, 2024
@feckert feckert deleted the pr/20240816-basicstation branch August 21, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants