-
Notifications
You must be signed in to change notification settings - Fork 3.8k
basicstation: fix compilation for new mbedtls version 3.x #24805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OpenWrt will change to the APK package manager which requires The PKG_RELEASE should be an integer and not contain any letters or special characters.
|
|
I am not so sure, upstream does not appear to be interested in their project anymore. It leads that if there is some security vulnerability, then we would be on our own. Same happens with bugs, etc. Your backported patch is for more than one month on review, it was not reviewed, but @gstrauss do the good job however. I think, we should drop this package and just move on. |
|
@aparcar this CI failure doesn't look right. |
| PKG_RELEASE:=2 | ||
|
|
||
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_URL:=https://codeload.github.com/lorabasics/basicstation/tar.gz/v$(PKG_VERSION)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to local tarballs should fix CI.
The datacenter went offline and I had to switch DNS/server, should work again. |
The basicstation build fails since the change to the new major version 3.x of mbedtls, because of API changes in the new mbedtls version. To fix the compilation for new mbedtls version, the waiting pullrequest is backported as a patch. Thanks to 'Glenn Strauss' to create this PR: lorabasics/basicstation#198 Signed-off-by: Florian Eckert <fe@dev.tdt.de>
12dde9c to
b366b54
Compare
I have now opened an issue to see if the project is still active |
|
Cool, APK is happy now. |
Maintainer: @mars642
Compile tested: x86_64
Run tested: no
Description:
The basicstation build fails since the change to the new major version 3.x of mbedtls, because of API changes in the new mbedtls version.
To fix the compilation for new mbedtls version, the waiting pullrequest is backported as a patch.
Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198