Skip to content

Conversation

@nemesifier
Copy link
Member

Made default locale, timezone and other settings more neutral.

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • N/A I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

@nemesifier nemesifier self-assigned this Jan 29, 2026
@nemesifier nemesifier added the enhancement New feature or request label Jan 29, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Environment and configuration values were updated across three files to reflect a geographic region change. The timezone was changed from Asia/Kolkata to UTC, and certificate subject fields were updated from Indian locations to Swiss locations: country code changed from IN to CH, state changed from Delhi to Geneva, and city changed from New Delhi to Geneva.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: making default locale settings more neutral.
Description check ✅ Passed The PR description is mostly complete, covering the intent of changes and confirming documentation updates, though it lacks reference to issue number and detailed change descriptions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9797ec7 and 2d562f2.

📒 Files selected for processing (3)
  • .env
  • docs/user/settings.rst
  • images/openwisp_base/Dockerfile
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/user/settings.rst
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
.env

[warning] 29-29: [UnorderedKey] The TZ key should go before the USE_OPENWISP_FIRMWARE key

(UnorderedKey)


[warning] 38-38: [UnorderedKey] The X509_COUNTRY_CODE key should go before the X509_NAME_CA key

(UnorderedKey)


[warning] 40-40: [UnorderedKey] The X509_CITY key should go before the X509_COUNTRY_CODE key

(UnorderedKey)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: CI Build
🔇 Additional comments (2)
.env (1)

29-29: LGTM! Neutral defaults are appropriate.

Using UTC and Switzerland/Geneva as defaults is a good choice for an open-source project with international users. UTC is the standard neutral timezone, and Geneva is commonly used as a neutral location for international organizations.

The dotenv-linter warnings about key ordering can be safely ignored here — the current organization groups related settings together semantically (X509_* fields together, timezone with additional settings), which is more maintainable than strict alphabetical ordering.

Also applies to: 38-40

images/openwisp_base/Dockerfile (1)

160-162: LGTM! Consistent with .env file.

The X509 certificate defaults are now aligned with the .env file, maintaining consistency across the configuration. The removal of quotes around Geneva (previously "New Delhi") is appropriate since it's a single word without spaces.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Made default locale, timezone and other settings more neutral.
@nemesifier nemesifier merged commit 2d562f2 into master Jan 29, 2026
5 checks passed
@nemesifier nemesifier deleted the default-locale branch January 29, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants