feat(ventilation): expose exhaust and extract temperatures and humidities plus heat recovery efficiency#695
Conversation
…ture, getExtractTemperature, and getHeatRecoveryEfficiency Co-authored-by: norschel <12895005+norschel@users.noreply.github.com>
…atRecoveryEfficiency methods Co-authored-by: norschel <12895005+norschel@users.noreply.github.com>
…ual API Co-authored-by: norschel <12895005+norschel@users.noreply.github.com>
Co-authored-by: norschel <12895005+norschel@users.noreply.github.com>
Add exhaust/extract temperature and humidity sensors and heat recovery efficiency methods to VentilationDevice
There was a problem hiding this comment.
Pull request overview
Extends ventilation device support to expose additional sensor readings (exhaust/extract temperature & humidity) and heat recovery efficiency, along with corresponding fixtures and unit tests to support Home Assistant ViCare component enhancements.
Changes:
- Added
getExhaustTemperature,getExtractTemperature,getExhaustHumidity,getExtractHumiditytoVentilationDevice. - Added
getHeatRecoveryEfficiencytoVentilationDevice. - Updated Vitopure350 test fixture JSON and added unit tests covering the new getters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
PyViCare/PyViCareVentilationDevice.py |
Adds new getter methods for additional ventilation sensor values and heat recovery efficiency. |
tests/test_Vitopure350.py |
Adds unit tests validating the new getters return expected values from the fixture. |
tests/response/Vitopure350.json |
Extends mocked API response data with the new features used by the added getters/tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…toairFs300E Co-authored-by: norschel <12895005+norschel@users.noreply.github.com>
…ir-fs-300e Move exhaust/extract sensor tests from Vitopure350 to VitoairFs300E
Fix JSON formatting by adding a newline at the end of the file.
CFenner
changed the title
There was a problem hiding this comment.
Please sort the datapoint to make future changes easy to review, see https://github.com/openviess/PyViCare?tab=readme-ov-file#more-different-devices-for-test-cases-needed
Also consider updating the whole file, we now have timestamps from 2024 and 2025 in here.
CFenner
left a comment
CFenner
left a comment
There was a problem hiding this comment.
Thanks for the addition!
Looks good so far, just one minor comment.
Please wait a moment. I need to check a few things. I'll let you know when I'm ready. |
This pull request extends the ventilation device support by adding new sensor readings and their corresponding tests, as well as updating the test response data to include these new features. The main changes are the addition of methods for retrieving exhaust and extract temperatures and humidities, as well as heat recovery efficiency, ensuring the library can access more detailed ventilation data.
The additional sensor data is needed for extending the HA Vicare component.
Ventilation sensor and efficiency support:
getExhaustTemperature,getExtractTemperature,getExhaustHumidity,getExtractHumidity, andgetHeatRecoveryEfficiencymethods toPyViCareVentilationDevice, allowing retrieval of additional sensor and efficiency data. [1] [2]Test coverage:
tests/test_Vitopure350.pyto verify correct retrieval of exhaust/extract temperature and humidity, as well as heat recovery efficiency.Test data updates:
tests/response/Vitopure350.jsonto include mock API responses for the new ventilation sensor and efficiency features, supporting the new tests and methods.