Rework documentation and cleanup scripts #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
yottta
force-pushed
the
rework-documentation
branch
from
96a50f6 to
f0a478e
Compare
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
yottta
force-pushed
the
rework-documentation
branch
from
313f118 to
a35506a
Compare
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
yottta
force-pushed
the
rework-documentation
branch
from
49e4510 to
77d6e92
Compare
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Even though GH redirects to the correct repository when cloning from the opentffoundation, that is clearly wrong and confusing. Replacing the old name of "opentffoundation" with "opentofu" Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
yottta
force-pushed
the
rework-documentation
branch
from
a12b8c8 to
e8d0520
Compare
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
yottta
commented
Nov 19, 2025
Contributor
Author
yottta
left a comment
yottta
left a comment
There was a problem hiding this comment.
Left some comments for some things that I wanted to point out in case somebody have something against or something to add.
In addition to that, please comment (or just update this branch with your own commits) with other information that you consider valuable for future usage of these scripts:
- what GPG keys are stored where? How those are generated for scripts vs terraform-provider-* repos (do all the repos have the same key? or any one of those have a different key?)
- do we have any terraform-provider-* repositories that shouldn't be managed by these scripts? (ie: lua?) If yes, why?
| ### [`gpg.yml`](./.github/workflows/gpg.yml) | ||
| This can generate new GPG keys for the provider repositories to use those for signing new releases. | ||
| > [!WARNING] | ||
| > From the looks of it, in the [gpg script](./go/gpg/main.go), the lifespan of such keys is hardcoded to 3 years. |
Contributor
Author
There was a problem hiding this comment.
If somebody can offer more context here on how the renewal of this should be handled, would be great to have it for the future.
lbordowitz
approved these changes
Nov 19, 2025
lbordowitz
left a comment
lbordowitz
left a comment
There was a problem hiding this comment.
All the READMEs made sense and gave me a good handle on how to run them and why.
Gogotchuri
approved these changes
Nov 20, 2025
Member
Gogotchuri
left a comment
Gogotchuri
left a comment
There was a problem hiding this comment.
Thanks for doing this work!
Made a lot simpler to understand what each part of this repository does.
cam72cam
approved these changes
Dec 4, 2025
Yantrio
reviewed
Dec 4, 2025
yottta
force-pushed
the
rework-documentation
branch
from
b91b6d6 to
9cda7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make clearer what scripts in this repo are for and how should be used together with the workflows.
The main points that I wanted to tackle (and it's up to the reviewer to say if it's enough or not) are as follows: