changes to highlights tests as per latest fixes #2765
Conversation
e2e_tests/e2e/ui/pages/home.py
Outdated
| await self.page.locator( | ||
| "p:has-text('formula. Repeat with values')" | ||
| ).select_text() | ||
| await self.page.locator("#fs-id1165134108431").select_text() |
There was a problem hiding this comment.
This method name in home.py is too generic for what it does which is selecting a specific element in a specific page of a specific book...
However, it would probably be an acceptable name if you just moved the method to the one test file that uses it, which is test_highlight_in_show_hide_solution.py
e2e_tests/e2e/ui/pages/home.py
Outdated
| await self.page.locator("#fs-id1165134108429").get_by_title( | ||
| "Show/Hide Solution" | ||
| await self.page.locator( | ||
| '#fs-id1165134108429[aria-label="Show/Hide Solution"]' |
There was a problem hiding this comment.
this I keep as is as there are 9 uses of this
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
.github/workflows/playwright.yml
Outdated
| python-version: '3.11' | ||
| cache: 'pip' # caching pip dependencies | ||
| - run: python -m pip install --upgrade pip | ||
| - run: pip install pytest-playwright |
There was a problem hiding this comment.
You already added this package to e2e_tests/requirements.txt so this line shouldn't be needed, it should install in the line below.
| async def clear_all_blockers(self): | ||
| await self.page.evaluate( | ||
| """() => { | ||
| document.querySelectorAll('div[class*="ClickBlocker"]').forEach(el => el.remove()); |
There was a problem hiding this comment.
Well my concern with removing it this way instead of clicking the X button is that you could leave other junk related to the modal around, which may interfere with tests in the future.
There was a problem hiding this comment.
I leave it for now but revisit it again
| await home.click_show_hide_solution_link() | ||
|
|
||
| await home.click_text_in_solution_block() | ||
| await home.clear_all_blockers() |
There was a problem hiding this comment.
I think the blocker is not related to clicking the solution link, it's related to loading the page, but maybe it has a delay, so I worry that this is flaky.
There was a problem hiding this comment.
I leave this as well for now and see how it goes
TomWoodward
requested a deployment
to
rex-web-newhi-2oayfkhyl3vyhinx
4 participants
https://openstax.atlassian.net/browse/CORE-988