Core 1521 abl partial data #439
Merged
+152
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop trying to copy secrets - New versions of ruby, ruby bundler, java, and swagger-codegen
Refactor Content.slugs_by_page_uuid to cache partial data (from broken books) with a 30-minute expiration, allowing recovery when books become available again. Full data continues to cache indefinitely. Also updates Ruby to 3.1.6, Java to openjdk-17, and upgrades gems.
There was a problem hiding this comment.
Pull request overview
This PR implements support for partial data handling in the ABL (Approved Book List) caching mechanism, allowing temporary caching when book processing encounters failures. It also includes infrastructure upgrades to Ruby 3.1.6, Java 17, and various gem dependencies.
Changes:
- Refactored
Content.slugs_by_page_uuidto explicitly handle partial data with time-limited caching (30 minutes) when ABL computation encounters broken books - Added comprehensive test coverage for the new caching behavior
- Upgraded infrastructure: Ruby 2.6.1 → 3.1.6, Java 8 → 17, Bundler 2.1.4 → 2.3.14, Swagger Codegen 2.4.13 → 3.0.35
- Updated gem dependencies including openstax_content 1.5.0 → 1.6.0
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/content.rb | Refactored caching logic to support partial_data flag with conditional expiration |
| spec/lib/content_spec.rb | New comprehensive test suite covering all caching scenarios and partial_data handling |
| Gemfile.lock | Updated gem dependencies including openstax_content and AWS SDK gems |
| Dockerfile | Upgraded Ruby version, Java version, bundler, and swagger-codegen; reorganized layer ordering |
| README.md | Added Docker setup instructions for openstax/exercises and openstax/tutor-js |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dantemss
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-1521