Skip to content

Tidy up the placement charm #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nobuto-m wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Tidy up the placement charm #154

nobuto-m wants to merge 5 commits into from

Conversation

@nobuto-m
Copy link
Contributor

@nobuto-m nobuto-m commented Mar 9, 2020

  • use explicit relation names
  • use the official charm name space
  • fix annotations since it hid the nova-c-c icon in Juju GUI

nobuto-m and others added 5 commits March 9, 2020 15:42
lourot
lourot suggested changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@lourot lourot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we need to do the same changes in newer bundles, e.g. bionic-ussuri, focal-ussuri, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lourot lourot lourot requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nobuto-m @lourot