STOR-2654: Add storage co check for vSphere hybird env

[radeore]

Verify Storage Cluster Operator Degradation for vSphere Hybrid Environments

Adds support for verifying that the Storage Cluster Operator degrades successfully when non-vSphere (Bare Metal) nodes are added to a vSphere OpenShift cluster. This validation is required for the hybrid environment feature (STOR-2620, OCP >=4.21).

Changes

• Added STORAGE_CO_DEGRADE_CHECK environment variable (default: "false") to control degradation verification
• When enabled, the script waits for Storage Cluster Operator to degrade after BM nodes join before patching the CSI driver

This change is backward compatible - existing jobs continue to work unchanged. New jobs can opt-in by setting STORAGE_CO_DEGRADE_CHECK=true.

[openshift-ci-robot]

@radeore: This pull request references STOR-2620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

Feature: https://issues.redhat.com/browse/STOR-2620
Add storage co degrade check to verify 4.21 feature STOR-2620: vSphere BM nodes support in mixed hybrid env

Verify Storage Cluster Operator Degradation for vSphere Hybrid Environments

Adds support for verifying that the Storage Cluster Operator degrades successfully when non-vSphere (Bare Metal) nodes are added to a vSphere OpenShift cluster. This validation is required for the hybrid environment feature (STOR-2620, OCP >=4.21).

Changes

• Added STORAGE_CO_DEGRADE_CHECK environment variable (default: "false") to control degradation verification
• When enabled, the script waits for Storage Cluster Operator to degrade after BM nodes join before patching the CSI driver

This change is backward compatible - existing jobs continue to work unchanged. New jobs can opt-in by setting STORAGE_CO_DEGRADE_CHECK=true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@radeore: This pull request references STOR-2620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

Feature: https://issues.redhat.com/browse/STOR-2620
Add storage co degrade check to verify 4.21 feature STOR-2620: vSphere BM nodes support in mixed hybrid env

Verify Storage Cluster Operator Degradation for vSphere Hybrid Environments

Adds support for verifying that the Storage Cluster Operator degrades successfully when non-vSphere (Bare Metal) nodes are added to a vSphere OpenShift cluster. This validation is required for the hybrid environment feature (STOR-2620, OCP >=4.21).

Changes

• Added STORAGE_CO_DEGRADE_CHECK environment variable (default: "false") to control degradation verification
• When enabled, the script waits for Storage Cluster Operator to degrade after BM nodes join before patching the CSI driver

This change is backward compatible - existing jobs continue to work unchanged. New jobs can opt-in by setting STORAGE_CO_DEGRADE_CHECK=true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@radeore: This pull request references STOR-2620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

Add storage co degrade check to verify 4.21 feature STOR-2620: vSphere BM nodes support in mixed hybrid env

Verify Storage Cluster Operator Degradation for vSphere Hybrid Environments

Adds support for verifying that the Storage Cluster Operator degrades successfully when non-vSphere (Bare Metal) nodes are added to a vSphere OpenShift cluster. This validation is required for the hybrid environment feature (STOR-2620, OCP >=4.21).

Changes

• Added STORAGE_CO_DEGRADE_CHECK environment variable (default: "false") to control degradation verification
• When enabled, the script waits for Storage Cluster Operator to degrade after BM nodes join before patching the CSI driver

This change is backward compatible - existing jobs continue to work unchanged. New jobs can opt-in by setting STORAGE_CO_DEGRADE_CHECK=true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@radeore: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-csi-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.22-e2e-vsphere-csi-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.21-e2e-vsphere-csi-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.20-e2e-vsphere-csi-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-ovn-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.22-e2e-vsphere-ovn-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.21-e2e-vsphere-ovn-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.20-e2e-vsphere-ovn-hybrid-env	openshift/vmware-vsphere-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.22-e2e-vsphere-ovn-hybrid-env	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-vsphere-ovn-hybrid-env	openshift/installer	presubmit	Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-vsphere-ovn-hybrid-env	openshift/installer	presubmit	Registry content changed
periodic-ci-openshift-release-master-nightly-4.22-e2e-vsphere-ovn-upi-hybrid-env	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env	N/A	periodic	Registry content changed
periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-hybrid-env	N/A	periodic	Registry content changed
periodic-ci-openshift-release-master-nightly-4.22-e2e-vsphere-ovn-hybrid-env	N/A	periodic	Registry content changed
periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-hybrid-env	N/A	periodic	Registry content changed
periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi-hybrid-env	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci-robot]

@radeore: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Add storage co degrade check to verify 4.21 feature STOR-2620: vSphere BM nodes support in mixed hybrid env

Verify Storage Cluster Operator Degradation for vSphere Hybrid Environments

Adds support for verifying that the Storage Cluster Operator degrades successfully when non-vSphere (Bare Metal) nodes are added to a vSphere OpenShift cluster. This validation is required for the hybrid environment feature (STOR-2620, OCP >=4.21).

Changes

• Added STORAGE_CO_DEGRADE_CHECK environment variable (default: "false") to control degradation verification
• When enabled, the script waits for Storage Cluster Operator to degrade after BM nodes join before patching the CSI driver

This change is backward compatible - existing jobs continue to work unchanged. New jobs can opt-in by setting STORAGE_CO_DEGRADE_CHECK=true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[radeore]

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-hybrid-env periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi-hybrid-env periodic-ci-openshift-release-master-nightly-4.22-e2e-vsphere-ovn-upi-hybrid-env

[openshift-ci-robot]

@radeore: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[duanwei33]

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-hybrid-env

[openshift-ci-robot]

@duanwei33: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Phaow]

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi-hybrid-env

[openshift-ci-robot]

@Phaow: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Phaow]

/retitle STOR-2654: Add storage co check for vSphere hybird env

[openshift-ci-robot]

@radeore: This pull request references STOR-2654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Verify Storage Cluster Operator Degradation for vSphere Hybrid Environments

Adds support for verifying that the Storage Cluster Operator degrades successfully when non-vSphere (Bare Metal) nodes are added to a vSphere OpenShift cluster. This validation is required for the hybrid environment feature (STOR-2620, OCP >=4.21).

Changes

• Added STORAGE_CO_DEGRADE_CHECK environment variable (default: "false") to control degradation verification
• When enabled, the script waits for Storage Cluster Operator to degrade after BM nodes join before patching the CSI driver

This change is backward compatible - existing jobs continue to work unchanged. New jobs can opt-in by setting STORAGE_CO_DEGRADE_CHECK=true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Phaow]

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-hybrid-env

[openshift-ci-robot]

@Phaow: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@radeore: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-hybrid-env	ce37964	link	unknown	/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-hybrid-env

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Phaow]

@vr4manta It seems in 4.20 jobs the install always failed of network cluster operator degrade, from the epic description we support the as Tech Preview from 4.21+, right? Could you please help review when you get a chance? Thank you! ^^

[Phaow]

/assign @vr4manta
cc @gnufied

[vr4manta]

@vr4manta It seems in 4.20 jobs the install always failed of network cluster operator degrade, from the epic description we support the as Tech Preview from 4.21+, right? Could you please help review when you get a chance? Thank you! ^^

Yes, I will take a look. It should be working.

In reviewing this PR, it looks the pj-rehearse failed due to CO degraded too. I'll check to see what is going on.

[vr4manta]

4.20 is hitting:

  - lastTransitionTime: "2025-12-15T07:45:09Z"
    message: 'Error while updating status of infrastructures.config.openshift.io/cluster:
      failed to apply / update (config.openshift.io/v1, Kind=Infrastructure) /cluster:
      Infrastructure.config.openshift.io "cluster" is invalid: [status.platformStatus.vsphere.apiServerInternalIPs:
      Invalid value: "null": platformStatus.vsphere.apiServerInternalIPs in body must
      be of type array: "null", status.platformStatus.vsphere.ingressIPs: Invalid
      value: "null": platformStatus.vsphere.ingressIPs in body must be of type array:
      "null", <nil>: Invalid value: "null": some validation rules were not checked
      because the object was invalid; correct the existing errors to complete validation]'

I cannot remember if this is something we fixed in 4.21 or if it was fixed another way. I'll check my 2025 brain to see what was the resolution.

[vr4manta]

This can be resolved by backporting the following fix: openshift/cluster-network-operator#2795

But i think the better thing to do is remove the 4.20 job since this was not TP ready at that time. I'll talk with team about this.

[vr4manta]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeore, vr4manta
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/release/OWNERS
• ci-operator/step-registry/ipi/install/vsphere/OWNERS [vr4manta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Phaow]

/pj-rehearse ack

[openshift-ci-robot]

@Phaow: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Phaow]

@vrutkovs @wking Could you help take a look when you get a chance? Thank you! ^^

[Phaow]

/assign @vrutkovs

[openshift-ci]

@Phaow: GitHub didn't allow me to assign the following users: vrutkovs.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Phaow]

/assign @wking