-
Notifications
You must be signed in to change notification settings - Fork 127
SDCICD-1717: add support for running krkn-ai's discover command using… #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@varunraokadaparthi: This pull request references SDCICD-1717 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varunraokadaparthi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
… executor
- Add KrknAI configuration struct with parameters (Mode, Namespace, PodLabel,
NodeLabel, SkipPodName, ConfigFile, OutputDir, ExtraParams, Verbose, KubeconfigContents) in config
- Add --run-krkn-ai flag to enable krkn-ai tests via command line
- Refactor executor to use direct methods for generating jobspec
- Add buildStandardJobSpec() and buildKrknAIJobSpec() methods on Executor
- Create Kubernetes secret for kubeconfig and mount it at ~/.kube/config
- Add dynamic container name handling for log retrieval (e2e-suite vs krkn-ai)
- krkn-ai.yaml stored in ${report_dir}/install/krkn-ai/test-run-results/
- Update waitForSuite() to handle both container types
- Populate KrknAIConfig from environment variables in adhoctestimages
Co-authored-by: ritmun <ritmun@redhat.com>
Co-authored-by: milie <milei@redhat.com>
Co-authored-by: cmancini <cmancini@redhat.com>
Co-authored-by: yiqzhang <yiqzhang@redhat.com>
Co-authored-by: Cursor AI <cursor@cursor.sh>
c806bf4 to
b608a05
Compare
|
@varunraokadaparthi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| viper.SetDefault(KrknAI.Mode, "discover") | ||
| _ = viper.BindEnv(KrknAI.Mode, "MODE") | ||
|
|
||
| viper.SetDefault(KrknAI.Namespace, "robot-shop") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep default as ".*"
… executor