Skip to content

Conversation

@varunraokadaparthi
Copy link
Contributor

… executor

  • Add KrknAI configuration struct with parameters (Mode, Namespace, PodLabel, NodeLabel, SkipPodName, ConfigFile, OutputDir, ExtraParams, Verbose, KubeconfigContents) in config
  • Add --run-krkn-ai flag to enable krkn-ai tests via command line
  • Refactor executor to use direct methods for generating jobspec
    • Add buildStandardJobSpec() and buildKrknAIJobSpec() methods on Executor
  • Create Kubernetes secret for kubeconfig and mount it at ~/.kube/config
  • Add dynamic container name handling for log retrieval (e2e-suite vs krkn-ai)
    • krkn-ai.yaml stored in ${report_dir}/install/krkn-ai/test-run-results/
  • Update waitForSuite() to handle both container types
  • Populate KrknAIConfig from environment variables in adhoctestimages

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2026

@varunraokadaparthi: This pull request references SDCICD-1717 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

… executor

  • Add KrknAI configuration struct with parameters (Mode, Namespace, PodLabel, NodeLabel, SkipPodName, ConfigFile, OutputDir, ExtraParams, Verbose, KubeconfigContents) in config
  • Add --run-krkn-ai flag to enable krkn-ai tests via command line
  • Refactor executor to use direct methods for generating jobspec
  • Add buildStandardJobSpec() and buildKrknAIJobSpec() methods on Executor
  • Create Kubernetes secret for kubeconfig and mount it at ~/.kube/config
  • Add dynamic container name handling for log retrieval (e2e-suite vs krkn-ai)
  • krkn-ai.yaml stored in ${report_dir}/install/krkn-ai/test-run-results/
  • Update waitForSuite() to handle both container types
  • Populate KrknAIConfig from environment variables in adhoctestimages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varunraokadaparthi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@varunraokadaparthi
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2026
… executor

- Add KrknAI configuration struct with parameters (Mode, Namespace, PodLabel,
  NodeLabel, SkipPodName, ConfigFile, OutputDir, ExtraParams, Verbose, KubeconfigContents) in config
- Add --run-krkn-ai flag to enable krkn-ai tests via command line
- Refactor executor to use direct methods for generating jobspec
  - Add buildStandardJobSpec() and buildKrknAIJobSpec() methods on Executor
- Create Kubernetes secret for kubeconfig and mount it at ~/.kube/config
- Add dynamic container name handling for log retrieval (e2e-suite vs krkn-ai)
  - krkn-ai.yaml stored in ${report_dir}/install/krkn-ai/test-run-results/
- Update waitForSuite() to handle both container types
- Populate KrknAIConfig from environment variables in adhoctestimages

Co-authored-by: ritmun <ritmun@redhat.com>
Co-authored-by: milie <milei@redhat.com>
Co-authored-by: cmancini <cmancini@redhat.com>
Co-authored-by: yiqzhang <yiqzhang@redhat.com>
Co-authored-by: Cursor AI <cursor@cursor.sh>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

@varunraokadaparthi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

viper.SetDefault(KrknAI.Mode, "discover")
_ = viper.BindEnv(KrknAI.Mode, "MODE")

viper.SetDefault(KrknAI.Namespace, "robot-shop")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep default as ".*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants