OCPBUGS-72604: remove top level dispatch into useEffect

[PeterYurkovich]

The primary cause of the infinite loop was a top level dispatch triggering a rerender into the same top level dispatch. This PR makes a few changes:

1. Place the top level dispatch into a useEffect
2. Refactor the code before the top level dispatch to remove conditionals so that we don't have the hook run conditionally

I'm not exactly sure what change caused this issue to show up since it's been merged for 7 months. My guess is the latest react-redux upgrade

[openshift-ci-robot]

@PeterYurkovich: This pull request references Jira Issue OCPBUGS-72604, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@PeterYurkovich: This pull request references Jira Issue OCPBUGS-72604, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

The primary cause of the infinite loop was a top level dispatch triggering a rerender into the same top level dispatch. This PR makes a few changes:

1. Place the top level dispatch into a useEffect
2. Refactor the code before the top level dispatch to remove conditionals so that we don't have the hook run conditionally

I'm not exactly sure what change caused this issue to show up since it's been merged for 7 months. My guess is the latest react-redux upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jgbernalp]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jgbernalp]

/test ?

[openshift-ci]

@jgbernalp: The following commands are available to trigger required jobs:

/test e2e-aws-ovn

/test images

/test lint

/test okd-scos-images

/test periodics-images

/test translations

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-alerts

/test e2e-aws-ovn-upgrade

/test e2e-coo

/test e2e-dashboards

/test e2e-hypershift-conformance

/test e2e-incidents

/test e2e-metrics

/test e2e-monitoring

/test e2e-monitoring-bvt

/test e2e-monitoring-dev

/test e2e-monitoring-reg

/test e2e-virtualization

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-monitoring-plugin-main-e2e-aws-ovn

pull-ci-openshift-monitoring-plugin-main-e2e-monitoring

pull-ci-openshift-monitoring-plugin-main-images

pull-ci-openshift-monitoring-plugin-main-lint

pull-ci-openshift-monitoring-plugin-main-okd-scos-images

pull-ci-openshift-monitoring-plugin-main-periodics-images

pull-ci-openshift-monitoring-plugin-main-translations

pull-ci-openshift-monitoring-plugin-main-verify-deps

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jgbernalp]

/test e2e-metrics

[openshift-ci]

@PeterYurkovich: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metrics	9d02b51	link	false	/test e2e-metrics

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.