CNF-21106: release-4.23: OpenShift only: Add missing dualStackAddressFamily to bgppeers

[andreaskaris]

The downstream bundle was missing this critical new parameter. Given that disableMP is completely ignored now by both FRRK8s and by metallb's built-in FRR, and given that dualStackAddressFamily always defaults to false, dualStack AF setups were no longer possible in OpenShift. Adding the parameter to the CRD fixes this issue.

Reported-at: https://issues.redhat.com/browse/CNF-21106

(cherry picked from commit e6eee2d)

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andreaskaris
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@andreaskaris: This pull request references CNF-21106 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.23.0" version, but no target version was set.

Details

In response to this:

The downstream bundle was missing this critical new parameter. Given that disableMP is completely ignored now by both FRRK8s and by metallb's built-in FRR, and given that dualStackAddressFamily always defaults to false, dualStack AF setups were no longer possible in OpenShift. Adding the parameter to the CRD fixes this issue.

Reported-at: https://issues.redhat.com/browse/CNF-21106

(cherry picked from commit e6eee2d)

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andreaskaris]

/retest

[andreaskaris]

/test metallb-e2e-metal

[openshift-ci]

@andreaskaris: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/metallb-e2e-metal	c645650	link	true	/test metallb-e2e-metal

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.