-
Notifications
You must be signed in to change notification settings - Fork 21
CNF-21106: main: Downstream only: Fix broken downstream bundle #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andreaskaris The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The downstream bundle was missing this critical new parameter. Given that disableMP is completely ignored now by both FRRK8s and by metallb's built-in FRR, and given that dualStackAddressFamily always defaults to false, dualStack AF setups were no longer possible in OpenShift. Adding the parameter to the CRD fixes this issue. Reported-at: https://issues.redhat.com/browse/CNF-21106 Signed-off-by: Andreas Karis <ak.karis@gmail.com>
d8f1617 to
e6eee2d
Compare
|
@andreaskaris: This pull request references CNF-21106 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@andreaskaris: This pull request references CNF-21106 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@andreaskaris: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The downstream bundle was missing this critical new parameter. Given
that disableMP is completely ignored now by both FRRK8s and by metallb's
built-in FRR, and given that dualStackAddressFamily always defaults to
false, dualStack AF setups were no longer possible in OpenShift.
Adding the parameter to the CRD fixes this issue.
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
Special notes for your reviewer:
Release note: