Skip to content

Conversation

@andreaskaris
Copy link

@andreaskaris andreaskaris commented Jan 7, 2026

The downstream bundle was missing this critical new parameter. Given
that disableMP is completely ignored now by both FRRK8s and by metallb's
built-in FRR, and given that dualStackAddressFamily always defaults to
false, dualStack AF setups were no longer possible in OpenShift.
Adding the parameter to the CRD fixes this issue.

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:


@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 7, 2026
@openshift-ci openshift-ci bot requested review from dougbtv and oribon January 7, 2026 16:11
@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andreaskaris
Once this PR has been reviewed and has the lgtm label, please assign oribon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreaskaris andreaskaris changed the title main: Downstream only: Fix broken downstream bundle WIP: main: Downstream only: Fix broken downstream bundle Jan 7, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2026
The downstream bundle was missing this critical new parameter. Given
that disableMP is completely ignored now by both FRRK8s and by metallb's
built-in FRR, and given that dualStackAddressFamily always defaults to
false, dualStack AF setups were no longer possible in OpenShift.
Adding the parameter to the CRD fixes this issue.

Reported-at: https://issues.redhat.com/browse/CNF-21106
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris andreaskaris force-pushed the fix-bundle-release-main branch from d8f1617 to e6eee2d Compare January 8, 2026 10:19
@andreaskaris andreaskaris changed the title WIP: main: Downstream only: Fix broken downstream bundle CNF-21106: main: Downstream only: Fix broken downstream bundle Jan 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2026

@andreaskaris: This pull request references CNF-21106 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

downstream bundle generation was broken because of commit 4db50df which introduced unresolved
conflict markers into file
prometheus-k8s_rbac.authorization.k8s.io_v1_rolebinding.yaml. That file's no longer needed, alongside a bunch of other files. In order to fix this:
rm -f bundle/manifests/*
make bundle
make bundle-release

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2026

@andreaskaris: This pull request references CNF-21106 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The downstream bundle was missing this critical new parameter. Given
that disableMP is completely ignored now by both FRRK8s and by metallb's
built-in FRR, and given that dualStackAddressFamily always defaults to
false, dualStack AF setups were no longer possible in OpenShift.
Adding the parameter to the CRD fixes this issue.

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2026

@andreaskaris: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andreaskaris
Copy link
Author

@oribon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants