Logging-ui-plugin test using real data

[anpingli]

• Run Logging UI test using real test data
• defined an individual entrypoint run-cypress-logging.sh
• update cypress:run:ci and web/cypress.config.ts to make the CI run as-is.
• Test Logging using both cluster-admin and common users
• Run Logging test on both Admin Console and Dev Console
• Run Logging test on both Observer->Logs, and Pod->aggr logs

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anpingli
Once this PR has been reviewed and has the lgtm label, please assign zhuje for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhuje]

/retest

[zhuje]

@anpingli There are some errors coming from the package-lock.json file, this is from prow logs:

npm error "npm ci" can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with "npm install" before continuing. npm error

[anpingli]

@zhuje All test pass now.

[anpingli]

@jgbernalp could you talk a look my PR?

[jgbernalp]

LGTM
@etmurasaki can you review if this is in line with what we have for other plugins

[anpingli]

@etmurasaki @jgbernalp Refactored the program to improve readability and maintainability, please take a look again.

[jgbernalp]

The ids seem to be specific to monitoring only, are they required here?

[anpingli]

I don't use data-test.ts directly. data-test.ts is used by some common function in these files I borrowed from monitoring-plugin. How about merge data-test.ts with test-ids.ts or change the directory of it?

For example:
changeNamespace, changePerspectiveTo
web/cypress/support/commands/utility-commands.ts
web/cypress/views/nav.ts

[etmurasaki]

I believe you can include IDs into your test-ids.ts only those you use for changeNamespace, changePerspectiveTo etc...

[anpingli]

I'd like to keep the utility files same with the origin, so I just need to copy new files from monitoring-ui plugins directly.

[jgbernalp]

The origin should not be the monitoring plugin, but the console itself. Maybe we can extract the console specific ids into a file and copy or reuse only that one. I believe it will make the code easier to understand, contribute and reason about if we only copy what we need and reduce the noise other ids, specific to monitoring only, might cause.

[anpingli]

Moved from src/components/data-test.ts. to web/cypress/fixtures/data-test.ts.

[anpingli]

Any suggestion how can we extract all from console? and the IDs are various in different OpenShift Versions.

[jgbernalp]

I think we can create a specific file in the monitoring plugin with ids related to the console, with their corresponding versions. Then copy it here. @etmurasaki WDYT?

[openshift-ci]

@anpingli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test-unit	be6f2a5	link	true	/test test-unit
ci/prow/images	be6f2a5	link	true	/test images
ci/prow/test-e2e	be6f2a5	link	true	/test test-e2e
ci/prow/lint	be6f2a5	link	true	/test lint
ci/prow/fips-image-scan	be6f2a5	link	true	/test fips-image-scan

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.