Skip to content

OLS-2494: Tests: Don't rely on --console-image location in args list #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyoto wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −8
Open

OLS-2494: Tests: Don't rely on --console-image location in args list #1321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 36 additions & 8 deletions tests/tests/lightspeed-install.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,22 +150,50 @@ describe('OLS UI', () => {
`oc get clusterserviceversion --namespace=${OLS.namespace} -o name --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
).then((result) => {
if (result.stderr === '') {
const csvname = result.stdout;
const csvName = result.stdout;
// If console image exists, replace it in CSV
cy.exec(
`oc scale --replicas=0 deployment/lightspeed-operator-controller-manager --namespace=${OLS.namespace} --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
);
cy.exec(
`oc patch ${csvname} --namespace=${OLS.namespace} --type='json' -p='[{"op": "replace", "path": "/spec/relatedImages/1/image", "value":"${Cypress.env('CONSOLE_IMAGE')}"}]' --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
`oc patch ${csvName} --namespace=${OLS.namespace} --type='json' -p='[{"op": "replace", "path": "/spec/relatedImages/1/image", "value":"${Cypress.env('CONSOLE_IMAGE')}"}]' --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
);
cy.exec(
`oc patch ${csvname} --namespace=${OLS.namespace} --type='json' -p='[{"op": "replace", "path": "/spec/install/spec/deployments/0/spec/template/spec/containers/0/args/8", "value":"--console-image=${Cypress.env('CONSOLE_IMAGE')}"}]' --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
);
cy.exec(
`oc scale --replicas=1 deployment/lightspeed-operator-controller-manager --namespace=${OLS.namespace} --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
);
`oc get ${csvName} --namespace=${OLS.namespace} -o json --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
).then((csvResult) => {
if (csvResult.stderr !== '') {
throw new Error(`Getting csv failed
Exit code: ${csvResult.exitCode}
Stdout:\n${csvResult.stdout}
Stderr:\n${csvResult.stderr}`);
}

const csv = JSON.parse(csvResult.stdout);
const args =
csv.spec.install.spec.deployments[0].spec.template.spec.containers[0].args.map(
(arg) =>
arg.startsWith('--console-image=')
? `--console-image=${Cypress.env('CONSOLE_IMAGE')}`
: arg,
);

const patch = JSON.stringify([
{
op: 'replace',
path: '/spec/install/spec/deployments/0/spec/template/spec/containers/0/args',
value: args,
},
]);
cy.exec(
`oc patch ${csvName} --namespace=${OLS.namespace} --type='json' -p='${patch}' --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
);

cy.exec(
`oc scale --replicas=1 deployment/lightspeed-operator-controller-manager --namespace=${OLS.namespace} --kubeconfig ${Cypress.env('KUBECONFIG_PATH')}`,
);
});
} else {
throw new Error(`Getting csv name failed
throw new Error(`Getting CSV name failed
Exit code: ${result.exitCode}
Stdout:\n${result.stdout}
Stderr:\n${result.stderr}`);
Expand Down