Skip to content

OLS-2340: PF5: Tests: Add data-test attributes to some elements to clean up tests #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kyoto wants to merge 2 commits into
base: pattern-fly-5
Choose a base branch
from
Open

OLS-2340: PF5: Tests: Add data-test attributes to some elements to clean up tests #1320

kyoto wants to merge 2 commits into from
+12 −6

Conversation

@kyoto
Copy link
Member

@kyoto kyoto commented Jan 14, 2026

Manual cherry-pick of #1317

@openshift-ci openshift-ci bot requested review from JoaoFula and xrajesh January 14, 2026 12:38
@kyoto kyoto changed the title PF5: Tests: Add data-test attributes to some elements to clean up tests OLS-2340: PF5: Tests: Add data-test attributes to some elements to clean up tests Jan 14, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2026 •
edited by openshift-ci bot
Loading

@kyoto: This pull request references OLS-2340 which is a valid jira issue.

Details

In response to this:

Manual cherry-pick of #1317

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyoto
Copy link
Member Author

kyoto commented Jan 14, 2026

/retest

2 similar comments
@kyoto
Copy link
Member Author

kyoto commented Jan 14, 2026

/retest

@kyoto
Copy link
Member Author

kyoto commented Jan 14, 2026

/retest

@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@xrajesh xrajesh Awaiting requested review from xrajesh

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kyoto @openshift-ci-robot