Skip to content

Conversation

@shay23bra
Copy link

update base image to ubi-minimal

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 12, 2026

@shay23bra: This pull request references MGMT-22131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

update base image to ubi-minimal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 12, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

Walkthrough

Dockerfile base image changed from OpenShift to Red Hat UBI minimal. Package manager transitioned from dnf to microdnf. Final stage now includes copying the server binary from the builder stage, configuring a non-root user (65532:65532), setting GODEBUG and GOGC environment variables, and defining an ENTRYPOINT.

Changes

Cohort / File(s) Summary
Dockerfile Updates
Dockerfile
Base image changed from registry.ci.openshift.org/ocp/4.20:base-rhel9 to registry.access.redhat.com/ubi9/ubi-minimal:latest@sha256:...; package manager updated from dnf to microdnf; final stage now includes server binary copy, non-root user configuration (65532:65532), environment variables (GODEBUG, GOGC), and ENTRYPOINT directive

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between bfda1b6 and 72dc68f.

📒 Files selected for processing (1)
  • Dockerfile
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • Dockerfile
🔇 Additional comments (3)
Dockerfile (3)

22-22: LGTM - Base image change with digest pinning.

Good use of SHA256 digest pinning for reproducible builds. The UBI minimal image reduces attack surface and image size.


27-27: LGTM - Correct package manager for ubi-minimal.

Using microdnf is appropriate for the UBI minimal base image, and the cleanup step helps minimize image size.


30-36: No action needed — server binary is actively used in deployment manifests.

The server binary is invoked in separate container definitions within the Kubernetes manifests (config/manager/manager.yaml and bundle/manifests/image-based-install-operator.clusterserviceversion.yaml). The COPY instruction on line 31 is necessary and should be retained.

Likely an incorrect or invalid review comment.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shay23bra
Once this PR has been reviewed and has the lgtm label, please assign oourfali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shay23bra
Copy link
Author

/retest

@giladravid16
Copy link
Contributor

/test e2e-ibio ibio-reinstall

@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

@shay23bra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@giladravid16
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants