Skip to content

Comments

GIE-388: dashboard empty flow#162

Open
kdoberst wants to merge 1 commit intoopenshift:mainfrom
kdoberst:GIE-388-dashboard-empty-flow
Open

GIE-388: dashboard empty flow#162
kdoberst wants to merge 1 commit intoopenshift:mainfrom
kdoberst:GIE-388-dashboard-empty-flow

Conversation

@kdoberst
Copy link
Contributor

@kdoberst kdoberst commented Feb 18, 2026

Description

This implements the new empty dashboard from chat flow. See the "Changes Made" section for more details

There are numerous area that are "stubbed in" that may need refinement in further PRs:

  1. What triggers the "Create a dashboard from ..." buttons? Right now we are looking for particular text string in the user's message.

  2. What should happen in the conversation when a user clicks on the "create from ..." button? Right now we add a "I created a template from scratch" type of text so the LLM knows what happened. We are currently showing this message along with the LLM's response.

  3. Where should the card to open/close the dashboard be located in the conversation - especially when returning to chat? For now it is displayed below the chat is always visible.

  4. What is the expectations/requirements for the /dashboards/new/path, /dashboards/new/templates, and /dashboards/edit/{id} paths. They aren't technically needed for the flow to work (we can use conversation ID) so they weren't implemented

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test updates

Related Issues

Fixes # GIE-388

Changes Made

  • When a user types in a particular string - for example create a dashboard there are two buttons (start with a template and start from scratch) displayed after the LLM response UNLESS there is already a dashboard attached to this chat - then the buttons will not be displayed
  • When the user clicks on the "Start from scratch" button, a new aladdindashboard instance is created including the conversation ID AND the two create buttons disappear AND the canvas is shown with the new dashboard AND a card to open/close the dashboard is shown in the chat window
  • An empty dashboard will have an empty "This dashboard is empty" message shown.
  • If a user returns to a chat that has a dashboard attached: the dashboard is shown AND there is a card to open/close the dashboard AND the buttons to create a dashboard are not shown
  • If a user returns to a chat that does NOT have a dashboard: Previous dashboard is closed. IF there is a user input that has a particular string, the create dashboard buttons will be shown
  • When a user clicks on the "Create a new dasbhoard" buttons on the HOME or LIBRARY page, A new chat is created with an automatically submitted user prompt to create a dashboard this will cause the two create a dashboard buttons to be displayed

Other technical changes

  • There was race conditions when clicking on the "Create a new dashboard" buttons on the HOME and LIBRARY page. I solved this and added the helper: useStartChatWithPrompt
  • When using the useStartChatWithPrompt helper, it uses a new route that passes the wanted prompt as a parameter. (I'm not overly sold on this approach but it did seem a little cleaner than adding another context)

Testing Done

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on different browsers/devices (if applicable)

Test Details:

Screenshots/Videos

Screen.Recording.2026-02-19.at.10.06.45.AM.mov

Definition of Done (DOD)

Code Quality

  • Code follows project style guidelines and conventions
  • Code has been self-reviewed for logic, readability, and best practices
  • No debugging code (console.logs, commented code, etc.) left behind
  • No linter errors or warnings introduced
  • Code is properly commented where necessary

Testing

  • Unit tests added/updated and passing
  • Integration tests added/updated (if applicable)
  • Manual testing completed successfully
  • Edge cases and error scenarios tested
  • No existing tests broken by changes

Documentation

  • Code documentation updated (JSDoc, inline comments)
  • README updated (if applicable)
  • User-facing documentation updated (if applicable)
  • CHANGELOG updated (if maintained)

Review & Quality

  • PR description is clear and complete
  • All related issues are linked
  • Breaking changes are clearly documented
  • Security implications considered and addressed
  • Performance impact assessed
  • Accessibility requirements met (if UI changes)

Pre-Merge

  • All CI/CD checks passing
  • At least one approval from code owner/reviewer
  • All review comments addressed or resolved
  • Branch is up to date with target branch
  • No merge conflicts

Additional Notes

Reviewer Guidance


@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2026

@kdoberst: This pull request references GIE-388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test updates

Related Issues

Fixes #

Changes Made

Testing Done

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on different browsers/devices (if applicable)

Test Details:

Screenshots/Videos

Click to expand

Definition of Done (DOD)

Code Quality

  • Code follows project style guidelines and conventions
  • Code has been self-reviewed for logic, readability, and best practices
  • No debugging code (console.logs, commented code, etc.) left behind
  • No linter errors or warnings introduced
  • Code is properly commented where necessary

Testing

  • Unit tests added/updated and passing
  • Integration tests added/updated (if applicable)
  • Manual testing completed successfully
  • Edge cases and error scenarios tested
  • No existing tests broken by changes

Documentation

  • Code documentation updated (JSDoc, inline comments)
  • README updated (if applicable)
  • User-facing documentation updated (if applicable)
  • CHANGELOG updated (if maintained)

Review & Quality

  • PR description is clear and complete
  • All related issues are linked
  • Breaking changes are clearly documented
  • Security implications considered and addressed
  • Performance impact assessed
  • Accessibility requirements met (if UI changes)

Pre-Merge

  • All CI/CD checks passing
  • At least one approval from code owner/reviewer
  • All review comments addressed or resolved
  • Branch is up to date with target branch
  • No merge conflicts

Additional Notes

Reviewer Guidance


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdoberst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
@kdoberst kdoberst force-pushed the GIE-388-dashboard-empty-flow branch from 4554934 to cc7d612 Compare February 19, 2026 14:29
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2026

@kdoberst: This pull request references GIE-388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

This implements the new empty dashboard from chat flow. See the "Changes Made" section for more details

There are numerous area that are "stubbed in" that may need refinement in further PRs:

  1. What triggers the "Create a dashboard from ..." buttons? Right now we are looking for particular text string in the user's message.

  2. What should happen in the conversation when a user clicks on the "create from ..." button? Right now we add a "I created a template from scratch" type of text so the LLM knows what happened. We are currently showing this message along with the LLM's response.

  3. Where should the card to open/close the dashboard be located in the conversation - especially when returning to chat? For now it is displayed below the chat is always visible.

  4. What is the expectations/requirements for the /dashboards/new/path, /dashboards/new/templates, and /dashboards/edit/{id} paths. They aren't technically needed for the flow to work (we can use conversation ID) so they weren't implemented

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test updates

Related Issues

Fixes # GIE-388

Changes Made

  • When a user types in a particular string - for example create a dashboard there are two buttons (start with a template and start from scratch) displayed after the LLM response UNLESS there is already a dashboard attached to this chat - then the buttons will not be displayed
  • When the user clicks on the "Start from scratch" button, a new aladdindashboard instance is created including the conversation ID AND the two create buttons disappear AND the canvas is shown with the new dashboard AND a card to open/close the dashboard is shown in the chat window
  • An empty dashboard will have an empty "This dashboard is empty" message shown.
  • If a user returns to a chat that has a dashboard attached: the dashboard is shown AND there is a card to open/close the dashboard AND the buttons to create a dashboard are not shown
  • If a user returns to a chat that does NOT have a dashboard: Previous dashboard is closed. IF there is a user input that has a particular string, the create dashboard buttons will be shown
  • When a user clicks on the "Create a new dasbhoard" buttons on the HOME or LIBRARY page, A new chat is created with an automatically submitted user prompt to create a dashboard this will cause the two create a dashboard buttons to be displayed

Other technical changes

  • There was race conditions when clicking on the "Create a new dashboard" buttons on the HOME and LIBRARY page. I solved this and added the helper: useStartChatWithPrompt
  • When using the useStartChatWithPrompt helper, it uses a new route that passes the wanted prompt as a parameter. (I'm not overly sold on this approach but it did seem a little cleaner than adding another context)

Testing Done

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on different browsers/devices (if applicable)

Test Details:

Screenshots/Videos

Screen.Recording.2026-02-19.at.10.06.45.AM.mov

Definition of Done (DOD)

Code Quality

  • Code follows project style guidelines and conventions
  • Code has been self-reviewed for logic, readability, and best practices
  • No debugging code (console.logs, commented code, etc.) left behind
  • No linter errors or warnings introduced
  • Code is properly commented where necessary

Testing

  • Unit tests added/updated and passing
  • Integration tests added/updated (if applicable)
  • Manual testing completed successfully
  • Edge cases and error scenarios tested
  • No existing tests broken by changes

Documentation

  • Code documentation updated (JSDoc, inline comments)
  • README updated (if applicable)
  • User-facing documentation updated (if applicable)
  • CHANGELOG updated (if maintained)

Review & Quality

  • PR description is clear and complete
  • All related issues are linked
  • Breaking changes are clearly documented
  • Security implications considered and addressed
  • Performance impact assessed
  • Accessibility requirements met (if UI changes)

Pre-Merge

  • All CI/CD checks passing
  • At least one approval from code owner/reviewer
  • All review comments addressed or resolved
  • Branch is up to date with target branch
  • No merge conflicts

Additional Notes

Reviewer Guidance


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kdoberst kdoberst marked this pull request as ready for review February 19, 2026 17:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

@kdoberst: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants