Skip to content

Comments

refactor: tool call arguments provided by NGUI#161

Draft
eyevana wants to merge 4 commits intomainfrom
refactor/ngui-pass-tool-args
Draft

refactor: tool call arguments provided by NGUI#161
eyevana wants to merge 4 commits intomainfrom
refactor/ngui-pass-tool-args

Conversation

@eyevana
Copy link
Contributor

@eyevana eyevana commented Feb 18, 2026

Description

Since https://issues.redhat.com/browse/NGUI-448 was completed, I no longer need to pull the arguments from the execute_range_query or execute_instant_query tool calls manually in the app in order to render the Perses components. Asa result, I don't have to pass tool call info down to the artifacts and I don't have to save it in the CRD to render the Perses components in the dashboard. I did have to modify the system prompt to direct the LLM to pass the arguments to NGUI though so that it can pass it to me in the generate_ui tool call response.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test updates

Related Issues

Fixes #

Changes Made

Testing Done

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on different browsers/devices (if applicable)

Test Details:

Screenshots/Videos

Click to expand

Definition of Done (DOD)

Code Quality

  • Code follows project style guidelines and conventions
  • Code has been self-reviewed for logic, readability, and best practices
  • No debugging code (console.logs, commented code, etc.) left behind
  • No linter errors or warnings introduced
  • Code is properly commented where necessary

Testing

  • Unit tests added/updated and passing
  • Integration tests added/updated (if applicable)
  • Manual testing completed successfully
  • Edge cases and error scenarios tested
  • No existing tests broken by changes

Documentation

  • Code documentation updated (JSDoc, inline comments)
  • README updated (if applicable)
  • User-facing documentation updated (if applicable)
  • CHANGELOG updated (if maintained)

Review & Quality

  • PR description is clear and complete
  • All related issues are linked
  • Breaking changes are clearly documented
  • Security implications considered and addressed
  • Performance impact assessed
  • Accessibility requirements met (if UI changes)

Pre-Merge

  • All CI/CD checks passing
  • At least one approval from code owner/reviewer
  • All review comments addressed or resolved
  • Branch is up to date with target branch
  • No merge conflicts

Additional Notes

Reviewer Guidance


@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eyevana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
@eyevana eyevana changed the title Refactor/ngui pass tool args refactor: tool call arguments provided by NGUI Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant