refactor: tool call arguments provided by NGUI#161
Draft
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eyevana The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since https://issues.redhat.com/browse/NGUI-448 was completed, I no longer need to pull the arguments from the
execute_range_queryorexecute_instant_querytool calls manually in the app in order to render the Perses components. Asa result, I don't have to pass tool call info down to the artifacts and I don't have to save it in the CRD to render the Perses components in the dashboard. I did have to modify the system prompt to direct the LLM to pass the arguments to NGUI though so that it can pass it to me in thegenerate_uitool call response.Type of Change
Related Issues
Fixes #
Changes Made
Testing Done
Test Details:
Screenshots/Videos
Click to expand
Definition of Done (DOD)
Code Quality
Testing
Documentation
Review & Quality
Pre-Merge
Additional Notes
Reviewer Guidance