-
Notifications
You must be signed in to change notification settings - Fork 213
Bump o/api #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump o/api #1288
Conversation
WalkthroughBumps Go toolchain from 1.24.0 to 1.25.0 and updates numerous direct and indirect dependencies; also updates CI build root image tag to use the Go 1.25-based RHEL image. No functional code or API signatures were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @go.mod:
- Line 3: The go version in the module directive ("go 1.25.0") is vulnerable;
update the module directive value from "go 1.25.0" to "go 1.25.2" (or later) in
the go.mod so the project is built with a Go release that includes CVE fixes and
then rebuild CI/artifacts with the new toolchain; ensure any build matrices or
Dockerfiles that pin Go are also updated to the same minimum version.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (299)
go.sumis excluded by!**/*.sumvendor/github.com/go-logr/logr/.golangci.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/go-logr/logr/funcr/funcr.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/format/format.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/gomega_dsl.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/assertion.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/async_assertion.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/duration_bundle.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/gomega.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/polling_signal_error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/internal/vetoptdesc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/and.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/assignable_to_type_of_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_a_directory.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_a_regular_file.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_an_existing_file.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_closed_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_comparable_to_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_element_of_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_empty_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_equivalent_to_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_false_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_identical_to.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_key_of_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_nil_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_numerically_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_sent_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_temporally_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_true_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/be_zero_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/consist_of.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/contain_element_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/contain_elements_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/contain_substring_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/equal_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_cap_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_each_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_exact_elements.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_existing_field_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_field.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_http_body_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_http_header_with_value_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_http_status_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_key_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_len_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_occurred_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_prefix_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_suffix_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/have_value.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_iter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_noiter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_error_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_json_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_regexp_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_xml_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/match_yaml_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/not.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/or.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/panic_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/receive_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/satisfy_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/semi_structured_data_support.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/succeed_matcher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraph.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/support/goraph/node/node.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/type_support.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/matchers/with_transform.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/onsi/gomega/types/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_authentication.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_cluster_image_policy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_cluster_version.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_feature.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_image_policy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/types_scheduling.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-CustomNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-Default.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-DevPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-OKD.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-TechPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-OKD.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-CustomNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-Default.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-DevPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-OKD.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-TechPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_clusterimagepolicies-Default.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_clusterimagepolicies-DevPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_clusterimagepolicies-TechPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_clusterimagepolicies.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_featuregates.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_imagepolicies-Default.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_imagepolicies-DevPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_imagepolicies-TechPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_imagepolicies.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-OKD.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_nodes-OKD.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_schedulers-SelfManagedHA-DevPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_schedulers-SelfManagedHA-OKD.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_schedulers-SelfManagedHA-TechPreviewNoUpgrade.crd.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.featuregated-crd-manifests.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1/zz_generated.swagger_doc_generated.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1alpha1/types_cluster_image_policy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1alpha1/types_image_policy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1alpha1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/config/v1alpha1/zz_generated.swagger_doc_generated.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/features/features.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/api/features/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/api/client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/desc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/internal/difflib.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/internal/go_runtime_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/labels.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/metric.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/process_collector_darwin.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/process_collector_mem_nocgo_darwin.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/process_collector_procfsenabled.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/promhttp/instrument_server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/vec.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/client_golang/prometheus/wrap.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/config/config.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/config/headers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/config/http_config.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/decode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/encode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/expfmt.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/fuzz.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/openmetrics_create.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/text_create.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/expfmt/text_parse.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/alert.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/labels.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/labelset.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/metric.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/time.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/value.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/value_histogram.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/common/model/value_type.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/Makefile.commonis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/arp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/fs.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/fs_statfs_notype.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/fscache.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/internal/fs/fs.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/internal/util/parse.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/internal/util/sysreadfile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/mountstats.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/net_dev_snmp6.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/net_ip_socket.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/net_protocols.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/net_tcp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/net_unix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_cgroup.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_io.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_netstat.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_smaps.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_snmp.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_snmp6.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_status.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/proc_sys.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/prometheus/procfs/softirqs.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/SECURITY.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/bool_func.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/count.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/flag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/func.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/golangflag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/ipnet_slice.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/string_to_string.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/text.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/time.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/filter.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/internal/attribute.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/rawhelpers.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/attribute/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/gen.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/internal/rawhelpers.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/auto.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/span.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/status.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/traces.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/internal/telemetry/value.gois excluded by!vendor/**,!**/vendor/**vendor/go.opentelemetry.io/otel/trace/noop.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/crypto/openpgp/s2k/s2k.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/context/context.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/html/escape.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/html/parse.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/html/render.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/config.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/config_go124.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/config_go125.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/config_go126.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/config_pre_go124.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/frame.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/gotrack.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/http2.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/server.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/timer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/transport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched_priority_rfc7540.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/writesched_roundrobin.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/internal/httpcommon/request.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/trace/events.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/clientcredentials/clientcredentials.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/internal/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/internal/oauth2.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/internal/token.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/internal/transport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/oauth2.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/pkce.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/token.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/oauth2/transport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/affinity_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/fdset.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ifreq_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/mkall.shis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_netbsd.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsyscall_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_netbsd_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/syscall_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/types_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/windows/zsyscall_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/term/terminal.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/japanese/eucjp.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/japanese/iso2022jp.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/japanese/shiftjis.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/korean/euckr.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/simplifiedchinese/gbk.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/simplifiedchinese/hzgb2312.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/traditionalchinese/big5.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/encoding/unicode/unicode.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/text/unicode/bidi/core.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/genproto/googleapis/rpc/status/status.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/encoding/protowire/wire.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/editiondefaults/editions_defaults.binpbis excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/filedesc/editions.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/filedesc/presence.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/genid/api_gen.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/genid/descriptor_gen.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/impl/codec_message_opaque.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/impl/message_opaque.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/impl/presence.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/strs/strings_unsafe.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/strs/strings_unsafe_go120.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/internal/version/version.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/proto/merge.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/reflect/protoreflect/source_gen.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/reflect/protoreflect/value_unsafe.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/reflect/protoreflect/value_unsafe_go120.gois excluded by!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/descriptorpb/descriptor.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/gofeaturespb/go_features.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/known/anypb/any.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/known/durationpb/duration.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/known/emptypb/empty.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/known/structpb/struct.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/known/timestamppb/timestamp.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/google.golang.org/protobuf/types/known/wrapperspb/wrappers.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/gopkg.in/evanphx/json-patch.v4/README.mdis excluded by!vendor/**,!**/vendor/**vendor/gopkg.in/evanphx/json-patch.v4/patch.gois excluded by!vendor/**,!**/vendor/**vendor/gopkg.in/yaml.v2/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/gopkg.in/yaml.v2/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/gopkg.in/yaml.v2/LICENSE.libyamlis excluded by!vendor/**,!**/vendor/**vendor/gopkg.in/yaml.v2/README.mdis excluded by!vendor/**,!**/vendor/**vendor/gopkg.in/yaml.v2/apic.gois excluded by!vendor/**,!**/vendor/**vendor/gopkg.in/yaml.v2/decode.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (1)
go.mod
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
go.mod
🔇 Additional comments (2)
go.mod (2)
24-25: Security status confirmed for golang.org/x/crypto v0.46.0 and golang.org/x/net v0.48.0. Both versions are free from known vulnerabilities and include necessary security patches. The version updates appropriately address recent security disclosures.
28-34: The k8s.io package upgrade from v0.34.x to v0.35.0 appears compatible with the codebase. Code analysis shows the cluster-version-operator uses standard client-go APIs (List operations, typed clients for CoreV1, BatchV1, etc.) in patterns compatible with v0.35.0. No breaking API changes in client-go v0.35.0 were identified that would affect this code.
| module github.com/openshift/cluster-version-operator | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Go 1.25.0 release date stable
💡 Result:
Go 1.25.0 (stable) was released on August 12, 2025. [1][2]
Sources:
[1] Go Release History — go.dev.
[2] "Go 1.25 is released" — The Go Blog.
🌐 Web query:
Go 1.25.0 security advisories known issues
💡 Result:
Short summary — known security issues affecting Go 1.25.0 (fixed in later 1.25.x releases, see notes):
- CVE-2025-58185 — encoding/asn1: unvalidated DER parsing can pre-allocate memory and lead to memory exhaustion (DoS). Fixed in 1.25.2. [1]
- CVE-2025-58183 — archive/tar: tar.Reader can allocate unbounded memory when parsing sparse regions (OOM DoS). Fixed in 1.25.2. [2]
- CVE-2025-58186 — net/http: cookie parsing could be abused to exhaust memory by sending many cookies. Fixed in 1.25.2. [3]
- CVE-2025-58188 — crypto/x509: certificate chain validation panic when encountering DSA public keys (availability impact). Fixed in 1.25.2. [4]
- CVE-2025-58189 — crypto/tls: ALPN handshake error can include unescaped attacker-controlled data in server error messages (information leakage / DoS vector). Fixed in 1.25.2. [5]
- CVE-2025-61724 — net/textproto: Reader.ReadResponse uses repeated concatenation and can cause excessive CPU usage on many-line responses. Fixed in 1.25.2. [6]
Recommendation: upgrade any systems using Go 1.25.0 to the patched release (1.25.2 or later) and rebuild binaries that embed the toolchain. [2][4]
Sources:
[1] Wiz — CVE-2025-58185.
[2] Wiz — CVE-2025-58183.
[3] Wiz — CVE-2025-58186.
[4] Wiz — CVE-2025-58188.
[5] Wiz — CVE-2025-58189.
[6] Wiz — CVE-2025-61724.
🌐 Web query:
Go programming language version 1.25 release
💡 Result:
Go 1.25 was released on August 12, 2025. Key highlights include toolchain and runtime improvements, DWARF‑5 debug output and linker size/time options, stricter nil‑check semantics (spec enforcement), the graduated testing/synctest package, an experimental encoding/json/v2 behind GOEXPERIMENT=jsonv2, new vet analyzers, and other standard‑library and go command enhancements. [1][2]
Sources:
[1] Go Blog — “Go 1.25 is released” (Aug 12, 2025).
[2] Go 1.25 Release Notes (go.dev/doc/go1.25).
Upgrade Go to 1.25.2 or later—Go 1.25.0 has critical security vulnerabilities.
Go 1.25.0 contains six known CVEs (all fixed in 1.25.2+):
- CVE-2025-58185 (encoding/asn1): memory exhaustion DoS
- CVE-2025-58183 (archive/tar): unbounded memory allocation DoS
- CVE-2025-58186 (net/http): cookie parsing DoS
- CVE-2025-58188 (crypto/x509): panic on DSA keys
- CVE-2025-58189 (crypto/tls): ALPN error information leakage
- CVE-2025-61724 (net/textproto): CPU exhaustion on many-line responses
Rebuild with Go 1.25.2 or later.
🤖 Prompt for AI Agents
In @go.mod at line 3, The go version in the module directive ("go 1.25.0") is
vulnerable; update the module directive value from "go 1.25.0" to "go 1.25.2"
(or later) in the go.mod so the project is built with a Go release that includes
CVE fixes and then rebuild CI/artifacts with the new toolchain; ensure any build
matrices or Dockerfiles that pin Go are also updated to the same minimum
version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.ci-operator.yaml:
- Around line 1-4: Update the FROM line in Dockerfile.rhel so the builder image
matches Go 1.25 used in go.mod and .ci-operator.yaml: replace the existing
rhel-9-golang-1.24-openshift-4.21 builder reference with the
rhel-9-golang-1.25-openshift-4.22 builder (the first FROM in Dockerfile.rhel /
the builder stage) to ensure CI and Docker build environments are consistent.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
.ci-operator.yaml
| build_root_image: | ||
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.24-openshift-4.21 | ||
| tag: rhel-9-release-golang-1.25-openshift-4.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# Check for go.mod or go.sum to find Go version
fd -e mod -e sum | head -20Repository: openshift/cluster-version-operator
Length of output: 91
🏁 Script executed:
# Search for Go version references in the codebase
rg "go.*1\.(2[4-5]|23)" -t go -t yaml -t dockerfile --max-count=20Repository: openshift/cluster-version-operator
Length of output: 112
🏁 Script executed:
# Look at the git log for recent changes and commit messages
git log --oneline -20Repository: openshift/cluster-version-operator
Length of output: 111
🏁 Script executed:
# Check if there are other references to golang image versions
rg "golang-1\.(2[3-5])" --max-count=20Repository: openshift/cluster-version-operator
Length of output: 181
🏁 Script executed:
# Check the Go version in go.mod
head -20 go.modRepository: openshift/cluster-version-operator
Length of output: 882
🏁 Script executed:
# Check what files were changed in this commit
git diff-tree --no-commit-id --name-only -r HEADRepository: openshift/cluster-version-operator
Length of output: 60
🏁 Script executed:
# Check if Dockerfile.rhel has changes
git show HEAD:Dockerfile.rhel | head -20Repository: openshift/cluster-version-operator
Length of output: 939
🏁 Script executed:
# Get the full diff for .ci-operator.yaml to see exact changes
git show HEAD:.ci-operator.yaml 2>/dev/null || cat .ci-operator.yamlRepository: openshift/cluster-version-operator
Length of output: 183
🏁 Script executed:
# Check if there are any staged or uncommitted changes for Dockerfile.rhel
git status | grep -i dockerfileRepository: openshift/cluster-version-operator
Length of output: 60
🏁 Script executed:
# Check the git log to see if Dockerfile.rhel was modified in related commits
git log --oneline --all -- Dockerfile.rhel | head -10Repository: openshift/cluster-version-operator
Length of output: 1398
🏁 Script executed:
# Search for all Dockerfile variants that might need updating
fd -t f "Dockerfile*"Repository: openshift/cluster-version-operator
Length of output: 93
🏁 Script executed:
# Check what files are in the current commit (HEAD)
git diff HEAD~1 HEAD --name-onlyRepository: openshift/cluster-version-operator
Length of output: 266
🏁 Script executed:
# Show the actual diff for this commit to see exactly what changed
git diff HEAD~1 HEADRepository: openshift/cluster-version-operator
Length of output: 266
🏁 Script executed:
# Check the actual current HEAD and git status
git status
git log --oneline -5Repository: openshift/cluster-version-operator
Length of output: 241
🏁 Script executed:
# Try to see the full commit for the current HEAD
git show HEADRepository: openshift/cluster-version-operator
Length of output: 50395
Update Dockerfile.rhel to use Go 1.25-based builder image.
The .ci-operator.yaml change to rhel-9-release-golang-1.25-openshift-4.22 must be paired with a corresponding update to Dockerfile.rhel. Currently, Dockerfile.rhel still references the 1.24-based builder image (rhel-9-golang-1.24-openshift-4.21), creating a mismatch:
go.moddeclares Go 1.25.0.ci-operator.yamlprovides Go 1.25 in CI build environmentDockerfile.rhelstill builds with Go 1.24
Update the FROM statement in Dockerfile.rhel line 1 to use the matching 1.25-based image:
FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-4.22 AS builder
🤖 Prompt for AI Agents
In @.ci-operator.yaml around lines 1 - 4, Update the FROM line in
Dockerfile.rhel so the builder image matches Go 1.25 used in go.mod and
.ci-operator.yaml: replace the existing rhel-9-golang-1.24-openshift-4.21
builder reference with the rhel-9-golang-1.25-openshift-4.22 builder (the first
FROM in Dockerfile.rhel / the builder stage) to ensure CI and Docker build
environments are consistent.
|
@hongkailiu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Required by #1284