-
Notifications
You must be signed in to change notification settings - Fork 213
More robust promql inject #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simonpasquier
wants to merge
2
commits into
openshift:main
Choose a base branch
from
simonpasquier:more-robust-promql-inject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/cluster-version-operator
Length of output: 86
🏁 Script executed:
Repository: openshift/cluster-version-operator
Length of output: 885
🌐 Web query:
prom-label-proxy v0.12.1 security vulnerabilities CVE💡 Result:
I couldn't find any CVE entries for prom-label-proxy v0.12.1. The project's GitHub/releases pages list the v0.12.x series but no security advisories or CVE IDs are published for that release. [1][2]
If you want, I can (a) monitor NVD/GHSA for new CVEs and alert you, or (b) run a focused dependency scan (SCA) against your image/artifacts to check for CVEs in dependencies. [1] https://github.com/prometheus-community/prom-label-proxy. [2] release listing / changelog for the project. [3] Snyk package page for related prom-label-proxy packages (no CVE for upstream prom-label-proxy v0.12.1 listed).
🌐 Web query:
prometheus client_golang v1.23.2 security vulnerabilities💡 Result:
Short answer: There are no public CVEs that specifically affect prometheus/client_golang v1.23.2. Known serious client_golang vulnerabilities (e.g., CVE‑2022‑21698 / GO‑2022‑0322 — promhttp unbounded cardinality DoS) were fixed in much earlier releases (fixed in v1.11.1); v1.23.2 is a 2025 maintenance release with no functional/security changes listed. [1][2]
Sources:
🌐 Web query:
prometheus v0.305.0 security vulnerabilities💡 Result:
I found one confirmed public CVE that lists v0.305.0 as an affected Prometheus version:
I did not find any separate/new high‑severity CVEs specifically introduced in the v0.305.0 release in the sources searched. For a complete, up‑to‑date inventory for your environment I recommend checking the NVD/MITRE entries and your distro/security advisories (they may map package builds to CVEs). Relevant sources: NVD CVE‑2019‑3826 and OpenHub version->vulnerability mapping. [1][2]
Sources
(If you want, I can run a deeper search across vendor advisories, GitHub issues, and distro trackers and return a full CVE list and mitigation steps.)
Investigate prometheus v0.305.0 — associated with CVE-2019-3826 (XSS vulnerability).
The addition of
prom-label-proxy v0.12.1appears secure with no known vulnerabilities, andprometheus/client_golang v1.23.2is a recent 2025 release with no active CVEs.However,
prometheus v0.305.0is flagged for CVE-2019-3826, a stored DOM cross-site scripting vulnerability affecting Prometheus versions below 2.7.1. The version number format (v0.305.0) is also unusual for modern Prometheus releases and should be verified — confirm whether this is the intended version or if it should be updated to a more recent release like v2.54.x or later.🤖 Prompt for AI Agents