CORENET-6311: Skip running _stackmanager for libreswan 5.3+ #2787
Conversation
pperiyasamy
force-pushed
the
libreswan-5.3
branch
2 times, most recently
from
c8da991 to
1d489fe
Compare
pperiyasamy
changed the title
| /usr/libexec/ipsec/_stackmanager start | ||
| # Check kernel modules only for libreswan version <= 5.2. The _stackmanager binary is | ||
| # removed from 5.3 onwards, so this check is not needed on later versions. | ||
| if [ -e /usr/libexec/ipsec/_stackmanager ]; then |
There was a problem hiding this comment.
One space should be enough. :)
Otherwise, lgtm.
The _stackmanager binary was removed in libreswan 5.3 and is no longer required for prerequisite checks. This commit conditionally runs _stackmanager only when the binary is present on the system. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
libreswan-5.3
branch
from
1d489fe to
53dbf9b
Compare
|
/retest-required |
|
@pperiyasamy if libreswan 5.3 is what we have in the OCP master, why do we still keep the code for versions <= 5.2? |
@pliurh currently master is still with libreswan 5.2. even if we bump libreswan version t0 5.3 in master, this script is still getting used when upgrading it from 5.2 to 5.3. |
|
/retest-required |
|
Note: will also need this change down to at least 4.19 as we'll get 5.3 there as soon as it is released. |
|
/approve |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pliurh, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pperiyasamy
changed the title
|
@pperiyasamy: This pull request references CORENET-6311 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/verified by "pre-merge testing" |
openshift-ci-robot
added
the
verified
|
@huiran0826: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 37d6525
into
openshift:master
|
/cherry-pick release-4.20 |
|
@pperiyasamy: new pull request created: #2872 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
The
_stackmanagerbinary was removed in libreswan 5.3 and is no longer required for prerequisite checks. This commit conditionally runs_stackmanageronly when the binary is present on the system.cc @huiran0826