OCPBUGS-64812: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.31 into release-4.19 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pýrus <kayrus@users.noreply.github.com>
Unblock the gate while we investigate the perforamnce regressions seen in Dalmatian (and possibly Caracal). python-barbicanclient does not have a 2023.2-eol tag so we can't use install from Git. Since we're not hacking on though there's no good reason to be installing from Git, so we remove both this and python-octaviaclient from the list. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Justin Lamp <justin.lamp@netways.de> Co-authored-by: Justin Lamp <justin.lamp@netways.de>
…hen --with-topology=False (kubernetes#2872) * cinder-csi-plugin, manila-csi-plugin: Correct formatting character %T prints the type. %t prints the word true/false, which is what we want. [1] [1] https://pkg.go.dev/fmt Conflicts: pkg/csi/manila/driver.go NOTE(stephenfin): Merge conflicts are due to the absence of PR kubernetes#2734, which we don't want to backport. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * cinder-csi-plugin: Don't report topology capability when --with-topology=False The 'PluginCapability_Service_VOLUME_ACCESSIBILITY_CONSTRAINTS' capability flag determines whether the provisioner attempts to look up topology information from the node or not [1][2]. If we report it but don't return topology information from the node, we end up with failures to provision [3]. Fix the issue by optionally reporting the capability, like Manila already does. [1] https://github.com/kubernetes-csi/external-provisioner/blob/17e2429e9f/pkg/controller/controller.go#L685-L700 [2] https://github.com/kubernetes-csi/external-provisioner/blob/17e2429e9f/pkg/controller/controller.go#L994-L996 [3] https://github.com/kubernetes-csi/external-provisioner/blob/17e2429e9f/pkg/controller/topology.go#L177 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * manila-csi-plugin: Unify some logging between cinder, manila Signed-off-by: Stephen Finucane <stephenfin@redhat.com> --------- Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Co-authored-by: pýrus <kayrus@users.noreply.github.com>
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: Manjunath Kumatagi <mkumatag@in.ibm.com>
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.19
branch
from
7f5b861 to
e29b651
Compare
* update alpine to latest patch release * update go
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.19
branch
from
e29b651 to
629a7e9
Compare
Co-authored-by: pýrus <kayrus@users.noreply.github.com>
Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.19
branch
from
629a7e9 to
62a0ffe
Compare
Co-authored-by: Ansou FALL <fallansou@gmail.com>
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.19
branch
from
62a0ffe to
2aa2409
Compare
* tests: Bump DevStack to Epoxy (2025.1) (kubernetes#2742) * tests: Prefer ginkgo timeout So that we actually get test results. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Align opts for Cinder, Manila tests Add a timeout to the Manila job and otherwise move some lines around. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Suffix image version While boskos will reap most resources for us, it doesn't reap images [1]. This has resulted in us using the same image for who knows how long at this point. Encode the Ubuntu version to prevent us picking up other version by mistake. [1] https://github.com/kubernetes-sigs/boskos/blob/5993cef5a1c719c33c0936d416b7d935058e1204/cmd/janitor/gcp_janitor.py#L46-L88 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Bump DevStack to Epoxy (2025.1) Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Bump amphora image Use the Ubuntu 24.04 version, rather than the 22.04 version. This aligns with what we're using for DevStack itself. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * devstack: Remove USE_PYTHON3 It's all Python 3 now, baby. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Install Ansible from Debian Testing Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Correct broken conditions Per the Ansible 2.19 porting guide [1]. [1] https://ansible.readthedocs.io/projects/ansible-core/devel/porting_guides/porting_guide_core_2.19.html Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Decrease device detach timeout Wait less time before retrying. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> --------- Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * Bump CSI test timeouts (kubernetes#2966) * Bump CSI test timeouts We have worked around Nova bug #2119114 by lowering the device detach threshold to 1 second. Unfortunately this still leaves us with a N seconds of additional runtime, where N is the number of device detaches incurred by our test suite (since we run tests serially). This has put us right on the cusp of timeouts, meaning our jobs occasionally pass and occasionally fail, depending on the node we end up on. Add a bit more breathing room for the jobs while we wait for the Nova fix. Note that we do this for both Cinder and Manila to try keep those jobs consistent where possible. [1] https://bugs.launchpad.net/nova/+bug/2119114 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> * tests: Temporarily remove share v1 endpoint Signed-off-by: Stephen Finucane <stephenfin@redhat.com> --------- Signed-off-by: Stephen Finucane <stephenfin@redhat.com> --------- Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
…1.31 into release-4.19
shiftstack-merge-bot-cloner
bot
force-pushed
the
merge-bot-release-4.19
branch
from
2aa2409 to
34f13e8
Compare
|
/retitle OCPBUGS-64812: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.31 into release-4.19 |
openshift-ci
bot
changed the title
openshift-ci
bot
added
the
ok-to-test
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci-robot
added
the
jira/invalid-bug
|
@shiftstack-merge-bot[bot]: This pull request references Jira Issue OCPBUGS-64812, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
needs-ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shiftstack-merge-bot[bot], stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@shiftstack-merge-bot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.