OCPBUGS-73750: [release-4.18] Fix pointers without ptr.Deref

[ricky-rav]

Manual cherry-pick of 16c498c.

The original PR 16c498c merged in 4.19 and the fix for the nil pointers was never backported.

It's a manual cherry pick because the commit in question was the last one in a large PR of 11 commits and of course a lot of the surrounding code had changed in the preceding commits.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricky-rav
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ricky-rav: This pull request references Jira Issue OCPBUGS-73750, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-73749 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-73749 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ricky-rav]

/test verify-deps

[openshift-ci]

@ricky-rav: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-ovn

/test e2e-azure-ovn

/test e2e-azure-serial

/test e2e-gcp-ovn

/test images

/test okd-scos-images

/test unit

The following commands are available to trigger optional jobs:

/test e2e-aws-ovn-serial

/test e2e-openstack-ovn-serial-e2e-only

/test okd-scos-e2e-aws-ovn

/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cloud-network-config-controller-release-4.18-e2e-aws-ovn

pull-ci-openshift-cloud-network-config-controller-release-4.18-e2e-azure-ovn

pull-ci-openshift-cloud-network-config-controller-release-4.18-e2e-azure-serial

pull-ci-openshift-cloud-network-config-controller-release-4.18-e2e-gcp-ovn

pull-ci-openshift-cloud-network-config-controller-release-4.18-images

pull-ci-openshift-cloud-network-config-controller-release-4.18-okd-scos-images

pull-ci-openshift-cloud-network-config-controller-release-4.18-security

pull-ci-openshift-cloud-network-config-controller-release-4.18-unit

Details

In response to this:

/test verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ricky-rav]

/retest

[openshift-ci]

@ricky-rav: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	28c4028	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ricky-rav: This pull request references Jira Issue OCPBUGS-73750, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-73749 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-73749 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Manual cherry-pick of 16c498c.

The original PR 16c498c merged in 4.19 and the fix for the nil pointers was never backported.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ricky-rav]

@kyrtapz PTAL. Thanks!