[OCPERT-210] Add OpenShift Tests Extension (OTE) integration by using the automated migration OTE tool #959
Conversation
…d migration OTE tool
- Create test/e2e/go.mod as separate module - Add openshift-tests-extension framework dependency - Add replace directives for k8s and OpenShift dependencies - Use Go version 1.24 from root module
- Copy 16 CCO test cases from openshift-tests-private - Add [OTP] annotation to all ported tests for tracking - Add [Level0] annotation to 3 conformance tests (33204, 36498, 66538) - Restructure test names: move Describe text into It() descriptions - Add testdata fixtures for cluster_operator tests - Generate bindata.go for embedded fixtures
- Create cmd/extension/main.go for cco-tests-ext binary - Filter tests to only include [sig-cco] tagged tests (16 tests) - Apply platform filters based on labels and test names - Update root go.mod with test/e2e replace directive - Add Makefile targets: tests-ext-build, extension, clean-extension - Add test/bindata.mk for testdata embedding with go-bindata
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ming1013: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cc |
huangmingxia
left a comment
huangmingxia
left a comment
There was a problem hiding this comment.
Thanks for the PR! The overall approach looks good, though there are a few adjustments needed. I've added some comments below - we can go through them together later.
| @@ -0,0 +1,104 @@ | |||
| package main | |||
There was a problem hiding this comment.
The OTE test framework has already been added to CCO, so this addition may be redundant.
Perhaps the prompt could be adjusted here to check whether the OTE test framework already exists and whether any update is needed.
| @@ -0,0 +1,906 @@ | |||
| package cloudcredential | |||
There was a problem hiding this comment.
We have set up the test/extend directory for QE test case related.
| @@ -0,0 +1,13 @@ | |||
| package cloudcredential | |||
There was a problem hiding this comment.
May I ask what this file is intended for?
| @@ -0,0 +1,366 @@ | |||
| module github.com/openshift/cloud-credential-operator/test/e2e | |||
There was a problem hiding this comment.
I wonder if creating a submodule is really needed here. However, we do not plan to introduce a submodule in CCO.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ming1013 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
OTE Migration Report - cloud-credential-operator
What Was Created
Extension Binary:
cmd/extension/main.go- Successfully builds to a 316MB binary atbin/cco-tests-extTest Module:
test/e2e/go.mod- Separate module with OTE dependenciesTestdata Infrastructure:
test/testdata/fixtures.go- Wrapper for accessing test fixturesBuild System: Updated Makefiles with
tests-ext-buildtargetModule Configuration: Root and test go.mod files properly configured with replace directives
Test Files Migrated
cloudcredential.go)cluster_operator/cloudcredential/)Build Verification
✅ Extension binary builds successfully
✅ Binary executes and shows help
✅ Suite registered:
openshift/cloud-credential-operator/tests✅ Tests discovered: 16 total, 3 Level0
The tests will be discovered and run when the extension is used within the OpenShift testing infrastructure.
Directory Structure