OCPBUGS-71221: test-ext: remove kubernetes module dependency #957

jstuever · 2026-01-07T18:33:24Z

When we added the test extension binary, it included code that forced the kubernetes module to be a requirement. This caused issue when using go list to list the modules. This code appears to be unnecessary.

This change removes that code and the kubernetes dependency with it. This allows the go mod list functionality to work as expected.

openshift-ci-robot · 2026-01-07T18:33:32Z

@jstuever: This pull request references Jira Issue OCPBUGS-71221, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When we added the test extension binary, it included code that forced the kubernetes module to be a requirement. This caused issue when using go list to list the modules. This code appears to be unnecessary.

This change removes that code and the kubernetes dependency with it. This allows the go mod list functionality to work as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jstuever · 2026-01-07T18:34:40Z

/backport release-4.21

jstuever · 2026-01-07T18:34:57Z

/jira backport release-4.21

openshift-ci-robot · 2026-01-07T18:35:10Z

@jstuever: The following backport issues have been created:

OCPBUGS-71222 for branch release-4.21

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

Details

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-01-07T18:35:13Z

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

@jstuever: The following backport issues have been created:

OCPBUGS-71222 for branch release-4.21

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

huangmingxia · 2026-01-07T18:38:15Z

/jira refresh

openshift-ci-robot · 2026-01-07T18:38:19Z

@huangmingxia: This pull request references Jira Issue OCPBUGS-71221, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huangmingxia

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

huangmingxia · 2026-01-07T18:49:37Z

/verified by ci run https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cloud-credential-operator/957/pull-ci-openshift-cloud-credential-operator-master-images/2008970257812688896

And local testing:

$ make cloud-credential-tests-ext
Makefile:93: warning: overriding recipe for target 'ensure-controller-gen'
vendor/github.com/openshift/build-machinery-go/make/targets/openshift/../../targets/openshift/controller-gen.mk:48: warning: ignoring old recipe for target 'ensure-controller-gen'
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO_COMPLIANCE_POLICY=exempt_all \
        go build -mod=vendor \
        -ldflags "-X github.com/openshift/cloud-credential-operator/pkg/version.versionFromGit=$(git describe --long --tags --abbrev=7 --match 'v[0-9]*' )" \
        ./cmd/cloud-credential-tests-ext
fatal: No names found, cannot describe anything.
$ ./cloud-credential-tests-ext list
[
  {
    "name": "[Jira:Cloud Credential Operator][sig-cco] Cluster_Operator CCO is enabled [Suite:cco/conformance/serial] should verify CCO operator is running and available",
    "labels": {},
    "resources": {
      "isolation": {}
    },
    "source": "openshift:payload:cloud-credential-operator",
    "codeLocations": [
      "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:8",
      "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:9"
    ],
    "lifecycle": "blocking",
    "environmentSelector": {}
  },
  {
    "name": "[Jira:Cloud Credential Operator][sig-cco] Cluster_Operator CCO is disabled [Suite:cco/optional/slow] should verify CCO operator is disabled",
    "labels": {},
    "resources": {
      "isolation": {}
    },
    "source": "openshift:payload:cloud-credential-operator",
    "codeLocations": [
      "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:14",
      "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:15"
    ],
    "lifecycle": "blocking",
    "environmentSelector": {}
  }
]

openshift-ci-robot · 2026-01-07T18:49:48Z

@huangmingxia: This PR has been marked as verified by ci run https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cloud-credential-operator/957/pull-ci-openshift-cloud-credential-operator-master-images/2008970257812688896.

Details

In response to this:

/verified by ci run https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cloud-credential-operator/957/pull-ci-openshift-cloud-credential-operator-master-images/2008970257812688896

And local testing:

$ make cloud-credential-tests-ext
Makefile:93: warning: overriding recipe for target 'ensure-controller-gen'
vendor/github.com/openshift/build-machinery-go/make/targets/openshift/../../targets/openshift/controller-gen.mk:48: warning: ignoring old recipe for target 'ensure-controller-gen'
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO_COMPLIANCE_POLICY=exempt_all \
       go build -mod=vendor \
       -ldflags "-X github.com/openshift/cloud-credential-operator/pkg/version.versionFromGit=$(git describe --long --tags --abbrev=7 --match 'v[0-9]*' )" \
       ./cmd/cloud-credential-tests-ext
fatal: No names found, cannot describe anything.
$ ./cloud-credential-tests-ext list
[
 {
   "name": "[Jira:Cloud Credential Operator][sig-cco] Cluster_Operator CCO is enabled [Suite:cco/conformance/serial] should verify CCO operator is running and available",
   "labels": {},
   "resources": {
     "isolation": {}
   },
   "source": "openshift:payload:cloud-credential-operator",
   "codeLocations": [
     "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:8",
     "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:9"
   ],
   "lifecycle": "blocking",
   "environmentSelector": {}
 },
 {
   "name": "[Jira:Cloud Credential Operator][sig-cco] Cluster_Operator CCO is disabled [Suite:cco/optional/slow] should verify CCO operator is disabled",
   "labels": {},
   "resources": {
     "isolation": {}
   },
   "source": "openshift:payload:cloud-credential-operator",
   "codeLocations": [
     "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:14",
     "/home/cloud-user/openshift/jeremiah/cloud-credential-operator/test/extend/cco.go:15"
   ],
   "lifecycle": "blocking",
   "environmentSelector": {}
 }
]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-01-07T18:50:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.48%. Comparing base (8f1a631) to head (aefb540).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   46.47%   46.48%   +0.01%     
==========================================
  Files          98       98              
  Lines       12184    12181       -3     
==========================================
  Hits         5662     5662              
+ Misses       5872     5869       -3     
  Partials      650      650

Files with missing lines	Coverage Δ
cmd/cloud-credential-tests-ext/main.go	`0.00% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

huangmingxia · 2026-01-07T20:01:42Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-proxy-oidc-mini-perm-amd-f28-destructive

openshift-ci · 2026-01-07T20:01:45Z

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-proxy-oidc-mini-perm-amd-f28-destructive

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b007bec0-ec03-11f0-84a7-f461164f505f-0

huangmingxia · 2026-01-07T20:03:22Z

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-ipi-disc-oidc-mini-perm-f14

openshift-ci · 2026-01-07T20:03:24Z

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-ipi-disc-oidc-mini-perm-f14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eb7955e0-ec03-11f0-8bb0-23c5f6306983-0

huangmingxia · 2026-01-07T20:05:14Z

/payload-job periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-aws-manual-oidc

openshift-ci · 2026-01-07T20:05:17Z

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-cloud-credential-operator-release-4.21-periodics-e2e-aws-manual-oidc

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2e1cd070-ec04-11f0-817d-56cdc3b3df05-0

huangmingxia · 2026-01-08T13:06:23Z

/retest

jstuever · 2026-01-08T20:06:20Z

/retest

jstuever · 2026-01-08T23:31:16Z

/assign @dlom

dlom · 2026-01-09T21:43:49Z

/lgtm

openshift-ci · 2026-01-09T21:44:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dlom,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-01-09T23:40:18Z

/retest-required

Remaining retests: 0 against base HEAD bf7cffc and 2 for PR HEAD aefb540 in total

huangmingxia · 2026-01-12T01:58:58Z

/test e2e-hypershift

openshift-ci · 2026-01-12T03:37:01Z

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-01-12T03:42:55Z

@jstuever: Jira Issue Verification Checks: Jira Issue OCPBUGS-71221
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-71221 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

When we added the test extension binary, it included code that forced the kubernetes module to be a requirement. This caused issue when using go list to list the modules. This code appears to be unnecessary.

This change removes that code and the kubernetes dependency with it. This allows the go mod list functionality to work as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-01-12T03:43:53Z

@openshift-ci-robot: new pull request created: #958

Details

In response to this:

@jstuever: The following backport issues have been created:

OCPBUGS-71222 for branch release-4.21

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2026-01-14T11:18:47Z

Fix included in accepted release 4.22.0-0.nightly-2026-01-14-031657

test-ext: remove kubernetes module dependency

aefb540

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 7, 2026

openshift-ci bot requested review from 2uasimojo, jianping-shu and suhanime January 7, 2026 18:33

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026

openshift-ci bot requested a review from huangmingxia January 7, 2026 18:38

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 7, 2026

openshift-ci bot assigned dlom Jan 8, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026

openshift-merge-bot bot merged commit ec9d4a0 into openshift:master Jan 12, 2026
12 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 12, 2026

[release-4.21] OCPBUGS-71222: test-ext: remove kubernetes module dependency #958

Open

OCPBUGS-71221: test-ext: remove kubernetes module dependency #957

OCPBUGS-71221: test-ext: remove kubernetes module dependency #957

Uh oh!

Conversation

jstuever commented Jan 7, 2026

Uh oh!

openshift-ci-robot commented Jan 7, 2026

Uh oh!

jstuever commented Jan 7, 2026

Uh oh!

jstuever commented Jan 7, 2026

Uh oh!

openshift-ci-robot commented Jan 7, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 7, 2026

Uh oh!

huangmingxia commented Jan 7, 2026

Uh oh!

openshift-ci-robot commented Jan 7, 2026

Uh oh!

huangmingxia commented Jan 7, 2026

Uh oh!

openshift-ci-robot commented Jan 7, 2026

Uh oh!

codecov bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huangmingxia commented Jan 7, 2026

Uh oh!

openshift-ci bot commented Jan 7, 2026

Uh oh!

huangmingxia commented Jan 7, 2026

Uh oh!

openshift-ci bot commented Jan 7, 2026

Uh oh!

huangmingxia commented Jan 7, 2026

Uh oh!

openshift-ci bot commented Jan 7, 2026

Uh oh!

huangmingxia commented Jan 8, 2026

Uh oh!

jstuever commented Jan 8, 2026

Uh oh!

jstuever commented Jan 8, 2026

Uh oh!

dlom commented Jan 9, 2026

Uh oh!

openshift-ci bot commented Jan 9, 2026

Uh oh!

openshift-ci-robot commented Jan 9, 2026

Uh oh!

huangmingxia commented Jan 12, 2026

Uh oh!

openshift-ci bot commented Jan 12, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 12, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 12, 2026

Uh oh!

openshift-merge-robot commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jan 7, 2026 •

edited

Loading