Skip to content

[release-4.20] OCPBUGS-74084: Require PreprovisioningImage for deprovisioning when cleaning is enabled #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.20
Choose a base branch
from
Open

[release-4.20] OCPBUGS-74084: Require PreprovisioningImage for deprovisioning when cleaning is enabled #446

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 19, 2026

This is an automated cherry-pick of #443

/assign elfosardo

@elfosardo
Require PreprovisioningImage for deprovisioning when cleaning is enabled
509ce2c 
When deprovisioning a host with automated cleaning enabled, BMO now:

1. Checks if a PreprovisioningImage is available before proceeding
   (in the provisioner's configureNode function)
2. Treats a PPI with a DeletionTimestamp as unavailable
   (in the controller's getPreprovImage function)

Previously, the StateDeprovisioning case was not handled, and PPIs
being deleted could still be used. This caused Ironic to fall back
to building its own ISO and fail with a misleading "uefi_esp.img
not found" error when the PPI was unavailable or being deleted.

Assisted-By: Claude Sonnet 4.5 (commercial license)

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
(cherry picked from commit c4631b5)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 19, 2026
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-67294 has been cloned as Jira Issue OCPBUGS-74084. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-74084: Require PreprovisioningImage for deprovisioning when cleaning is enabled

Details

In response to this:

This is an automated cherry-pick of #443

/assign elfosardo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-67294: Require PreprovisioningImage for deprovisioning when cleaning is enabled [release-4.20] OCPBUGS-74084: Require PreprovisioningImage for deprovisioning when cleaning is enabled Jan 19, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 19, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-74084, which is invalid:

  • expected dependent Jira Issue OCPBUGS-67294 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-67294 to target a version in 4.21.0, but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #443

/assign elfosardo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from derekhiggins and zaneb January 19, 2026 10:34
@elfosardo
Copy link

elfosardo commented Jan 28, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2026

@elfosardo: This pull request references Jira Issue OCPBUGS-74084, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link

elfosardo commented Jan 28, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 28, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2026

@elfosardo: This pull request references Jira Issue OCPBUGS-74084, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-67294 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-67294 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jadhaj January 28, 2026 08:29
@elfosardo
Copy link

elfosardo commented Jan 28, 2026

/retest

@elfosardo
Copy link

elfosardo commented Jan 28, 2026

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@zaneb zaneb Awaiting requested review from zaneb

@jadhaj jadhaj Awaiting requested review from jadhaj

Assignees

@elfosardo elfosardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @elfosardo