Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #39 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 7 7
Lines 109 109
Branches 25 25
=======================================
Hits 106 106
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
rokh/events/jalali.py
Outdated
| {'description': 'روز بزرگداشت صائب تبریزی', 'is_holiday': False}, | ||
| {'description': 'روز دیپلماسی فرهنگی و تعامل با جهان', 'is_holiday': False}, | ||
| {'description': 'آزادسازی شهر مهران', 'is_holiday': False}, | ||
| {'description': 'بزرگداشت صائب تبریزی', 'is_holiday': False}], |
|
@sepandhaghighi @Amirsaeed7 I can't open [Bahesab[(https://www.bahesab.ir/) probably due the Iran's connection situations. What should we do? |
Based on your past reviews i think what you need is the list of events for each month for both 1404 and 1405 . |
Yeah, download the HTML file of the month(s) so I can open them all here. |
In this folder i provided 8 text files containing the html data of the list of events of Bahesab Calendar in first four month for both 1404 and 1405 years. |
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
Good job; I reviewed them all and they are look good.
Good! I will review this pull request in the next 24 hours 🔥 |
rokh/events/jalali.py
Outdated
| {'description': 'تأسیس بنیاد مسکن انقلاب اسلامی', 'is_holiday': False}], | ||
| '23': [{'description': 'روز دندانپزشک', 'is_holiday': False}], | ||
| '25': [{'description': 'روز بزرگداشت عطار نیشابوری', 'is_holiday': False}], | ||
| '27': [{'description': 'روز فرهنگ پهلوانی و ورزش زورخانهای', 'is_holiday': False},], |
There was a problem hiding this comment.
This event was based on an Hijri event happend on "17 شوال" which i added to Hijri calendar but forgot to remove from the Jalali one.
Now it's fixed.
4 participants
In this PR i added events of the first four month from the Bahesab Calendar
here are the questions i wanted to ask:
30 Farvardin --> " روز آزمایشگاهیان" and 'روز علوم آزمایشگاهی، زادروز حکیم سید اسماعیل جرجانی' are these both events needed?
In the bahesab calendar the date of this event (شهادت امام محمد تقی علیه السلام) is "29 ذی القعده" but in the previous code it is mentioned as 30th of the month but based on my research it is on the 30th
is both this events needed "شلیک به پرواز 655 ایران ایر توسط ناو وینسنس [ 1367 خورشیدی ]" and "حمله ناوگان آمریکا به هواپیمای مسافربری جمهوری اسلامی ایران"