Bahesab calendar last four months

[Amirsaeed7]

In this PR i added events of Azar, Day, Bahman and Esfand from the Bahesab calendar

There's one important question and two minor questions i wanted to ask

1- There are many events that their origin is based on an event from Hijri calendar but were mentioned in Jalali calendar too
for example the birthday of "امام علی (ع)" in the Rajab 13th is considered as "روز پدر" in the Dey 13th but its Jalali date will be changed next year as the Hijri date stays the same
such events should be considered in Jalali events or not?

2- Is both event needed (25 December "ولادت عیسی مسیح" and "جشن کریسمس" )?

3- The event in the 7th December from our previous source was "روز جهانی هوانوردی غیرنظامی" but in the new source it is translated as "روز جهانی هواپیمایی" which one should i use?

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (6c808e2) to head (d3f1d6e).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev      #38   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files           7        7           
  Lines         109      109           
  Branches       25       25           
=======================================
  Hits          106      106           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sepandhaghighi]

@Amirsaeed7

Thank you for your efforts. Regarding your questions:

1. I'm not sure about what you mentioned, as I checked the 1405 calendar and found that the 13th Dey is not Father's Day. Nevertheless, the dates are completely related to the Hijri-Jalali calendar and should only be applied to this calendar.

2. Yes, let's keep both of them.

3. I prefer "روز جهانی هوانوردی غیرنظامی"

[Amirsaeed7]

There is an event called "روز جهانی قدس" which is in the last friday of Ramadan and has no fixed date in the Hijri calendar
what should we do with this kind of events?

[Amirsaeed7]

I wanted to mention i didn't remove the event "روز پاسدار" which is based on an event in Hijri calendar because it was already there and i was told to do not remove anything from the past code
if it's necessary to remove tell me.

[sepandhaghighi]

There is an event called "روز جهانی قدس" which is in the last friday of Ramadan and has no fixed date in the Hijri calendar what should we do with this kind of events?

@Amirsaeed7
That's a good point. I forgot to mention these types of events. We should remove events that do not have a fixed date for now, and we will address them later.

[sepandhaghighi]

@sadrasabouri Please review this PR 💯

[sadrasabouri]

Thank you @Amirsaeed7; here are my comments:

ps1: my reference was Bahesab_1405. When I wasn't sure about the origin of an event I cross-referenced that event with last years calendar, Bahesab_1404.

ps2: as a separate note @sepandhaghighi for consistency I think we should decide if we want to have روز as a prefix word for the events or we remove all روزs.

[sepandhaghighi]

@Amirsaeed7,
Thank you for your efforts! 💯
Please take a look at the comments.

[sadrasabouri]

Thanks for your efforts @Amirsaeed7 . I resolved the comments that were fixed. Take a look at others that are still open.

[Amirsaeed7]

Thanks for your efforts @Amirsaeed7 . I resolved the comments that were fixed. Take a look at others that are still open.

@sadrasabouri I commented on other conversations too. If you could answer my questions i will apply needed changes.

[sadrasabouri]

@Amirsaeed7 I can't see your comments on my comments but here are my answers to you intial questions:

1- There are many events that their origin is based on an event from Hijri calendar but were mentioned in Jalali calendar too for example the birthday of "امام علی (ع)" in the Rajab 13th is considered as "روز پدر" in the Dey 13th but its Jalali date will be changed next year as the Hijri date stays the same such events should be considered in Jalali events or not?

I think for these joint events, we should have both of them in the Hijri calendar.

2- Is both event needed (25 December "ولادت عیسی مسیح" and "جشن کریسمس" )?

Yes, I think we need both of them; Christmas has a more cultural connotation.

3- The event in the 7th December from our previous source was "روز جهانی هوانوردی غیرنظامی" but in the new source it is translated as "روز جهانی هواپیمایی" which one should i use?

same as @sepandhaghighi mentioned I prefer "روز جهانی هوانوردی غیرنظامی" too

[Amirsaeed7]

What about "آخرین روز سال" event
should i keep it or remove it?

[sadrasabouri]

What about "آخرین روز سال" event should i keep it or remove it?

we can keep that one; that's a different issue (leap years) that we should handle in future @sepandhaghighi

[Amirsaeed7]

@sadrasabouri I commented on your comments again
If you can't see them still there might be something wrong about the way I'm making those comments
Let me know if they're visible or not.

[sadrasabouri]

@sadrasabouri I commented on your comments again If you can't see them still there might be something wrong about the way I'm making those comments Let me know if they're visible or not.

yeah it's weird. Nope I still can not see your comments. Consult this with @sepandhaghighi next time you guys meet.

[Amirsaeed7]

@sadrasabouri About the two events that you mentioned you couldn't find any reference for i rechecked them and they were included in the Bahesab Calendar
If it is enough as the reference we could keep it.
what do you think?

[Amirsaeed7]

@sadrasabouri About the "روز پاسدار" event i explained earlier in this comment
#38 (comment)
I consulted with @sepandhaghighi and it was decided to keep it and fix all the similar issues from the past resources all at once

[sadrasabouri]

@sadrasabouri About the two events that you mentioned you couldn't find any reference for i rechecked them and they were included in the Bahesab Calendar If it is enough as the reference we could keep it. what do you think?

Can you send the exact link you checked here?

[Amirsaeed7]

@sadrasabouri About the two events that you mentioned you couldn't find any reference for i rechecked them and they were included in the Bahesab Calendar If it is enough as the reference we could keep it. what do you think?

Can you send the exact link you checked here?

You mean the exact link that shows they're mentioned in Bahesab Calendar?

[sadrasabouri]

@sadrasabouri About the two events that you mentioned you couldn't find any reference for i rechecked them and they were included in the Bahesab Calendar If it is enough as the reference we could keep it. what do you think?

Can you send the exact link you checked here?

You mean the exact link that shows they're mentioned in Bahesab Calendar?

yes

[Amirsaeed7]

@sadrasabouri About the two events that you mentioned you couldn't find any reference for i rechecked them and they were included in the Bahesab Calendar If it is enough as the reference we could keep it. what do you think?

Can you send the exact link you checked here?

You mean the exact link that shows they're mentioned in Bahesab Calendar?

yes

on this link https://www.bahesab.ir/time/calendar/ if you check the Dey 7th and Azar 18th on every calendar year contain the same events as i used.
p.s : I couldn't provide the exact link because selecting a date doesn't trigger specefic URL

[sadrasabouri]

@sadrasabouri About the two events that you mentioned you couldn't find any reference for i rechecked them and they were included in the Bahesab Calendar If it is enough as the reference we could keep it. what do you think?

Can you send the exact link you checked here?

You mean the exact link that shows they're mentioned in Bahesab Calendar?

yes

on this link https://www.bahesab.ir/time/calendar/ if you check the Dey 7th and Azar 18th on every calendar year contain the same events as i used. p.s : I couldn't provide the exact link because selecting a date doesn't trigger specefic URL

OK nice, now I see them; I was checking the all-in-one event list which is apparaently a subset of the event showing per-month. That's alright now; I will re-review it now and let you know.

[sadrasabouri]

Looks good to me know. Well done!

[sepandhaghighi]

🔥